Opened 12 years ago
Closed 12 years ago
#29725 closed defect (bug) (fixed)
Media library arrow key navigation is triggered in textareas
| Reported by: | essha | Owned by: | wonderboymusic |
|---|---|---|---|
| Priority: | low | Milestone: | 4.0.1 |
| Component: | Media | Version: | 4.0 |
| Severity: | trivial | Keywords: | has-patch fixed-major |
| Cc: | Focuses: | accessibility, javascript |
Description
This is a follow-up to #28704.
Event is fired on arrow keys when you enter textarea, i.e. caption and description.
Please exlude TEXTAREA from event trigger as well.
https://core.trac.wordpress.org/attachment/ticket/28704/28704.diff
Attachments (1)
Change History (12)
#1
@
12 years ago
- Summary Media library arrow keys: exclude nodeName → Media library arrow key navigation is triggered in textareas
#3
@
12 years ago
- Focuses accessibility javascript added
- Keywords has-patch commit added
- Milestone Awaiting Review → 4.0.1
- Priority normal → low
- Severity normal → trivial
- Type enhancement → defect (bug)
#5
@
12 years ago
- Keywords fixed-major added; commit removed
- Resolution fixed
- Status closed → reopened
This ticket was mentioned in Slack in #core by jorbin. View the logs.
12 years ago
#7
@
12 years ago
I verified that r29777 applies correctly to the 4.0 branch and fixes the described issue. Tested in chrome 38 and 40 along with FF.
This is ready to be merged.
This ticket was mentioned in Slack in #core by ocean90. View the logs.
12 years ago
Note:
See TracTickets
for help on using tickets.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
Ran into this problem last night- the keyEvent function returns when the event target is an input, but not on textareas, so editing the captions becomes very frustrating (since the attachment changes out from under you).
29725.diff adds
textareato the conditional, and also switches to nodeName based on azaozz's comment on r29332.