Opened 10 years ago
Closed 10 years ago
#29739 closed defect (bug) (fixed)
Context for Media grid trash
Reported by: | pavelevap | Owned by: | SergeyBiryukov |
---|---|---|---|
Milestone: | 4.1 | Priority: | normal |
Severity: | normal | Version: | 4.0 |
Component: | I18N | Keywords: | |
Focuses: | Cc: |
Description
New Media grid has "Trash" string in dropdown (meaning Trashed items), but also the same string "Trash" is used as verb for links (meaning to trash). So, context would be very helpfull here...
See attached patch...
BTW, I could not find where "Close uploader" string can be seen? I tried everything with media modals (also checking source for screen readers), but I did not notice it anywhere, any idea?
Attachments (2)
Change History (5)
#2
@
10 years ago
Thank you, Sergey, you are right. There are following strings:
Trash wp-includes/media-template.php:418 wp-includes/media-template.php:521 wp-includes/media.php:2935 Trash (post) wp-includes/post.php:147 Trash (verb) wp-admin/includes/class-wp-comments-list-table.php:471 wp-admin/includes/dashboard.php:560
So, in the end we do not need new string and there will be still right context, please see new patch...
Note: See
TracTickets for help on using
tickets.
We use
_x( 'Trash', 'verb' )
in a couple of places. I guess it should be_x( 'Trash', 'noun' )
here.