WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#29739 closed defect (bug) (fixed)

Context for Media grid trash

Reported by: pavelevap Owned by: SergeyBiryukov
Milestone: 4.1 Priority: normal
Severity: normal Version: 4.0
Component: I18N Keywords:
Focuses: Cc:
PR Number:

Description

New Media grid has "Trash" string in dropdown (meaning Trashed items), but also the same string "Trash" is used as verb for links (meaning to trash). So, context would be very helpfull here...

See attached patch...

BTW, I could not find where "Close uploader" string can be seen? I tried everything with media modals (also checking source for screen readers), but I did not notice it anywhere, any idea?

Attachments (2)

media_trash_context.patch (894 bytes) - added by pavelevap 5 years ago.
29739.patch (1.9 KB) - added by pavelevap 5 years ago.

Download all attachments as: .zip

Change History (5)

#1 @SergeyBiryukov
5 years ago

  • Milestone changed from Awaiting Review to 4.1

We use _x( 'Trash', 'verb' ) in a couple of places. I guess it should be _x( 'Trash', 'noun' ) here.

#2 @pavelevap
5 years ago

Thank you, Sergey, you are right. There are following strings:

Trash
wp-includes/media-template.php:418
wp-includes/media-template.php:521
wp-includes/media.php:2935

Trash (post)
wp-includes/post.php:147

Trash (verb)
wp-admin/includes/class-wp-comments-list-table.php:471
wp-admin/includes/dashboard.php:560

So, in the end we do not need new string and there will be still right context, please see new patch...

@pavelevap
5 years ago

#3 @SergeyBiryukov
5 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 29764:

Add context for 'Trash' string in media modal.

props pavelevap.
fixes #29739.

Note: See TracTickets for help on using tickets.