![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Opened 12 years ago
Closed 12 years ago
#29743 closed task (blessed) (fixed)
warning with join in nav-menu-template.php (L 98) when apply_filters nav_menu_css_class return null
| Reported by: | eadoking | Owned by: | johnbillion |
|---|---|---|---|
| Priority: | normal | Milestone: | 4.1 |
| Component: | Menus | Version: | 4.1 |
| Severity: | normal | Keywords: | needs-patch revert |
| Cc: | Focuses: |
Description
there is a warning because apply_filters on nav_menu_css_class return null and a warning happens in join clause , file "nav-menu-template.php" line 98
Attachments (1)
Change History (9)
This ticket was mentioned in Slack in #core by briandichiara. View the logs.
12 years ago
#5
@
12 years ago
- Resolution fixed
- Status closed → reopened
there is a warning because apply_filters on nav_menu_css_class return null
I think this should be considered a developer error. If the goal is to remove the classes, __return_empty_array() should be used here instead of __return_null().
But if we're going to keep [30032], we should do the same for body_class, post_class, comment_class, and page_css_class filters as well.
Note:
See TracTickets
for help on using tickets.
patch for nav-menu-template.php, resolves notices when non-array passed through filter