WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 6 years ago

#29744 closed defect (bug) (fixed)

Media Library: type dropdown in grid mode different form list mode + no count

Reported by: iseulde Owned by: wonderboymusic
Milestone: 4.4 Priority: normal
Severity: normal Version: 4.0
Component: Media Keywords: has-patch
Focuses: Cc:

Description

The dropdown in list mode excludes types that are empty while the one in grid mode does not. In list mode you can also see the count next to the type AND next to the pagination, while in grid mode there's no way to know the count.

Attachments (3)

Screen Shot 2014-09-24 at 08.50.44.png (19.3 KB) - added by iseulde 7 years ago.
Screen Shot 2014-09-24 at 08.51.13.png (16.0 KB) - added by iseulde 7 years ago.
29744.diff (3.9 KB) - added by wonderboymusic 6 years ago.

Download all attachments as: .zip

Change History (8)

#1 @iseulde
7 years ago

See screenshots above.

#2 @wonderboymusic
7 years ago

  • Milestone changed from Awaiting Review to Future Release

#3 @helen
7 years ago

I think we should remove the counts - it's confusing when you filter by more than one thing, which is actually possible now.

@wonderboymusic
6 years ago

#4 @wonderboymusic
6 years ago

  • Keywords has-patch added
  • Milestone changed from Future Release to 4.4

29744.diff ditches the counts and unifies the dropdowns

#5 @wonderboymusic
6 years ago

  • Owner set to wonderboymusic
  • Resolution set to fixed
  • Status changed from new to closed

In 34256:

Media List Table: remove the counts from the "views" portion of the toolbar, which are inconsistent with grid view. Also reduces complexity and removes potentially expensive count query.

Related to the toolbar view, remove the wp_admin_canonical_url() action in grid mode. Grid views that result from links from the list table view are lenses into the library and need to be indicated as such vs being a full attachment query.

Fixes #29744.

Note: See TracTickets for help on using tickets.