WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#29751 closed defect (bug) (fixed)

Merge results strings

Reported by: pavelevap's profile pavelevap Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 4.1 Priority: normal
Severity: normal Version: 4.0
Component: I18N Keywords:
Focuses: Cc:

Description

We have 2 almost same strings for search results in menu metaboxes and link window in visual editor. It should be merged, I guess. See attached patch...

Attachments (1)

merge_result_strings.patch​ (1.3 KB) - added by pavelevap 11 years ago.

Download all attachments as: .zip

Change History (6)

@pavelevap
11 years ago

#1 @SergeyBiryukov
11 years ago

  • Milestone changed from Awaiting Review to 4.1

I think we can also remove the context (added in [14285]) to merge the string with the one used in wp-admin/includes/nav-menu.php​.

#2 @SergeyBiryukov
11 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 29768:

Merge two similar strings.

props pavelevap.
fixes #29751.

#3 @TobiasBg
11 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

_x( 'No results found.' ) in [29768] will break due to a missing parameter.
It should be __( 'No results found.' ).

#4 @SergeyBiryukov
11 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 29769:

Use correct i18n function after [29768].

props TobiasBg.
fixes #29751.

#5 @pavelevap
11 years ago

Thank you, Sergey. So there were two similar strings removed in the end, nice...

Note: See TracTickets for help on using tickets.