WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#29753 closed defect (bug) (fixed)

CSS rules removing strong in string (plugin card)

Reported by: pavelevap's profile pavelevap Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 4.1 Priority: normal
Severity: normal Version: 4.0
Component: Plugins Keywords: has-patch
Focuses: Cc:

Description

We are using strong in following string:

<strong>Untested</strong> with your version of WordPress

But then removing it by CSS. I am not sure if I am missing something, but CSS part should be removed, I guess (or strong from string). See attached patch...

Attachments (1)

css_strong.patch​ (393 bytes) - added by pavelevap 11 years ago.

Download all attachments as: .zip

Change History (7)

@pavelevap
11 years ago

#1 @voldemortensen
11 years ago

  • Keywords has-patch added

#2 @SergeyBiryukov
11 years ago

I think this is intentional, so that the emphasis is only on "Compatible" or "Incompatible" strings.

#3 @pavelevap
11 years ago

Sergey: OK, but why we have CSS rule and strong tag in this string? We can remove both CSS rule and strong tags?

#4 @SergeyBiryukov
11 years ago

  • Milestone changed from Awaiting Review to 4.1

Yeah, I guess we can.

#5 @SergeyBiryukov
11 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 29775:

Remove unnecessary CSS overriding on Add Plugins screen.

props pavelevap.
fixes #29753.

#6 @nacin
11 years ago

The intention here, FWIW, was so we could introduce the strings, get them translated, and then decide on the exact styling. These strings came pretty late in the 4.0 cycle, and helen and I weren't sure how they'd be styled, but we knew that they'd say.

Changing it now is no problem.

Note: See TracTickets for help on using tickets.