Make WordPress Core

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#29754 closed defect (bug) (fixed)

Filtering plugin reviews does not work

Reported by: pavelevap's profile pavelevap Owned by: originalexe's profile OriginalEXE
Milestone: 4.1 Priority: normal
Severity: normal Version: 4.0
Component: Plugins Keywords: good-first-bug has-patch
Focuses: Cc:

Description

When installing plugin, in a modal window you can click on number of stars to filter reviews:

Click to see reviews that provided a rating of %d star

But it does not work for me...

Attachments (1)

29754.patch (1.2 KB) - added by OriginalEXE 11 years ago.

Download all attachments as: .zip

Change History (8)

#1 @SergeyBiryukov
11 years ago

  • Milestone changed from Awaiting Review to 4.1
  • Version changed from trunk to 4.0

Confirmed. All star links lead to the same URL:

http://trunk.wordpress/wp-admin/plugin-install.php?tab=plugin-information&plugin=...&section=reviews

#2 @OriginalEXE
11 years ago

  • Keywords dev-feedback added

Confirmed,

I looked into this and it seems like plugins api does not support fetching reviews based on ratings filter.

Possible solutions as I see it:
1.) Remove those links
2.) Switch them with links to wordpress.org repo where filtering actually works
3.) Add additional filter for the API so that reviews body can be fetched with only appropriate ratings

#3 @SergeyBiryukov
11 years ago

  • Keywords needs-patch good-first-bug added; dev-feedback removed

Let's go with option 2 for now.

@OriginalEXE
11 years ago

#4 @OriginalEXE
11 years ago

  • Keywords has-patch added; needs-patch removed

#5 @SergeyBiryukov
11 years ago

  • Owner set to OriginalEXE
  • Status changed from new to assigned

#6 @SergeyBiryukov
11 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 29826:

Use correct links for filtering plugin reviews.

props OriginalEXE.
fixes #29754.

#7 @SergeyBiryukov
11 years ago

#29874 was marked as a duplicate.

Note: See TracTickets for help on using tickets.