WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#29765 closed defect (bug) (fixed)

row actions and focusin focusout

Reported by: afercia Owned by: SergeyBiryukov
Milestone: 4.2 Priority: normal
Severity: normal Version: 4.0
Component: Comments Keywords: has-patch needs-testing
Focuses: ui, javascript Cc:

Description

Several kinds of listings have hidden "row actions" that are then revealed on mouse hover and on "focusin". In the specific case of comments listings, when tabbing in the Comments screen they're correctly revealed but in the Edit Post screen they don't. See screenshot:

https://cldup.com/dMsJFvretx.png

In the Edit Post screen, comments are not ready on DOM ready :) focusin and focusout events need to be delegated.

A second issue is caused by the setTimeout used on focusout: it's needed for Firefox so it can't be removed but then Chrome doesn't remove the "visible" CSS class when there are no other focusable elements between the selected elements. This happens just in few places, for example in the Dashboard, see second screenshot where all the previous "row-actions" stay visible:

https://cldup.com/SkRQ1M4gpM.png

Proposed patch delegates focusin and focusout and tries to give a little help to Chrome.

Attachments (3)

29765.patch (1.8 KB) - added by afercia 7 years ago.
29765.2.patch (1.8 KB) - added by afercia 7 years ago.
refreshed patch after r31173
29765.3.patch (1.8 KB) - added by SergeyBiryukov 7 years ago.

Download all attachments as: .zip

Change History (11)

@afercia
7 years ago

#1 @afercia
7 years ago

  • Keywords has-patch needs-testing added

@afercia
7 years ago

refreshed patch after r31173

#2 @afercia
7 years ago

Refreshed patch after r31173, removes also some debugging stuff left over.

#3 @SergeyBiryukov
7 years ago

  • Milestone changed from Awaiting Review to 4.2

This ticket was mentioned in Slack in #core by afercia. View the logs.


7 years ago

#5 @afercia
7 years ago

Patch needs a new refresh after r31177

#6 @DrewAPicture
7 years ago

  • Keywords needs-refresh added

Patch still needs a refresh.

#7 @SergeyBiryukov
7 years ago

  • Keywords needs-refresh removed

Refreshed.

#8 @SergeyBiryukov
7 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 31509:

Delegate focusin and focusout events for row actions to make sure the actions are always revealed on focus.

props afercia.
fixes #29765.

Note: See TracTickets for help on using tickets.