WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#29766 closed defect (bug) (fixed)

Comments listings empty author IP link

Reported by: afercia Owned by: SergeyBiryukov
Milestone: 4.1 Priority: normal
Severity: normal Version: 4.0
Component: Comments Keywords: has-patch needs-testing
Focuses: ui Cc:

Description

If, for any reason, comment_author_IP() returns an empty string, an empty link will be printed in the Comments listings. When tabbing with the keyboard, this link can be activated and it's a useless tab stop for keyboard users.
In Firefox the empty link is clearly visible when focused, while in Chrome it's a bit more difficult to spot, see screenshot:

https://cldup.com/erCUaGj7cf.png

Proposed patch prints the link just if comment_author_IP is not empty.

Attachments (1)

29766.patch (922 bytes) - added by afercia 6 years ago.

Download all attachments as: .zip

Change History (5)

@afercia
6 years ago

#1 @afercia
6 years ago

  • Keywords has-patch needs-testing added

#2 @afercia
6 years ago

wrong screenshot :)

https://cldup.com/Wofv-qHyHU.png

#3 @SergeyBiryukov
6 years ago

  • Milestone changed from Awaiting Review to 4.1

#4 @SergeyBiryukov
6 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 29774:

Don't display an empty comment author IP link on Comments screen.

props afercia.
fixes #29766.

Note: See TracTickets for help on using tickets.