WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#29769 closed enhancement (wontfix)

Let's give users a friendly reminder to backup before they upgrade their network as well.

Reported by: NikV Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Text Changes Keywords: has-patch
Focuses: ui, administration, multisite Cc:

Description

The upgrade page for upgrading the entire Network doesn't have a lot going on content-wise. But with that, I think if users should be strongly reminded the importance of backing up their site. This was achieved in the same manner (An admin notice) that is taken from the Update Core administration panel. A simple little fix, but definitely will help users understand what they're doing.

Attachments (3)

upgrade.php.diff (907 bytes) - added by NikV 5 years ago.
upgrade-revised.php.diff (891 bytes) - added by NikV 5 years ago.
Making a small revision with the HTML in this file.
upgrade-revised2.php.diff (926 bytes) - added by NikV 4 years ago.

Download all attachments as: .zip

Change History (11)

@NikV
5 years ago

#1 @NikV
5 years ago

  • Keywords has-patch added

@NikV
5 years ago

Making a small revision with the HTML in this file.

#2 follow-ups: @chriscct7
5 years ago

This patch needs to be updated to follow the WordPress standards. HTML shouldn't be inside a localized string as it doesn't need to be translated. See HTML section on http://codex.wordpress.org/I18n_for_WordPress_Developers

#3 in reply to: ↑ 2 @NikV
4 years ago

Replying to chriscct7:

This patch needs to be updated to follow the WordPress standards. HTML shouldn't be inside a localized string as it doesn't need to be translated. See HTML section on http://codex.wordpress.org/I18n_for_WordPress_Developers

Alright, thanks for the feedback. Should be fixed with my latest patch.

#4 @DrewAPicture
4 years ago

  • Component changed from Networks and Sites to Text Changes

#5 @helen
4 years ago

  • Version trunk deleted

#6 in reply to: ↑ 2 ; follow-up: @SergeyBiryukov
4 years ago

Replying to chriscct7:

HTML shouldn't be inside a localized string as it doesn't need to be translated. See HTML section on http://codex.wordpress.org/I18n_for_WordPress_Developers

upgrade-revised.php.diff is actually perfectly fine from a translator's point of view, and appears to be using an existing string. Codex links can be translated as well, so that section does not apply here.

My concern with the patch is that database upgrades are generally safe and not intensive, so the additional reminder is probably not needed.

See comment:5:ticket:7965, which suggests removing the extra database update step in single site.

Last edited 4 years ago by SergeyBiryukov (previous) (diff)

#7 in reply to: ↑ 6 @NikV
4 years ago

Replying to SergeyBiryukov:

Replying to chriscct7:

HTML shouldn't be inside a localized string as it doesn't need to be translated. See HTML section on http://codex.wordpress.org/I18n_for_WordPress_Developers

upgrade-revised.php.diff is actually perfectly fine from a translator's point of view, and appears to using an existing string. Codex links can be translated as well, so that section does not apply here.

My concern with the patch is that database upgrades are generally safe and not intensive, so the additional reminder is probably not needed.

See comment:5:ticket:7965, which suggests removing the extra database update step in single site.

Thanks for the feedback. That makes sense, not sure what to do, I suppose we could just close up this ticket then if it seems that it REALLY isn't needed at this point.

#8 @wonderboymusic
4 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.