Let's give users a friendly reminder to backup before they upgrade their network as well.

[NikV]

The upgrade page for upgrading the entire Network doesn't have a lot going on content-wise. But with that, I think if users should be strongly reminded the importance of backing up their site. This was achieved in the same manner (An admin notice) that is taken from the Update Core administration panel. A simple little fix, but definitely will help users understand what they're doing.

[NikV]

Making a small revision with the HTML in this file.

[chriscct7]

This patch needs to be updated to follow the WordPress standards. HTML shouldn't be inside a localized string as it doesn't need to be translated. See HTML section on ​http://codex.wordpress.org/I18n_for_WordPress_Developers

[NikV]

Replying to chriscct7:

This patch needs to be updated to follow the WordPress standards. HTML shouldn't be inside a localized string as it doesn't need to be translated. See HTML section on ​http://codex.wordpress.org/I18n_for_WordPress_Developers

Alright, thanks for the feedback. Should be fixed with my latest patch.

[SergeyBiryukov]

Replying to chriscct7:

HTML shouldn't be inside a localized string as it doesn't need to be translated. See HTML section on ​http://codex.wordpress.org/I18n_for_WordPress_Developers

upgrade-revised.php.diff​ is actually perfectly fine from a translator's point of view, and appears to be using an existing string​. Codex links can be translated as well, so that section does not apply here.

My concern with the patch is that database upgrades are generally safe and not intensive, so the additional reminder is probably not needed.

See comment:5:ticket:7965, which suggests removing the extra database update step in single site.

[NikV]

Replying to SergeyBiryukov:

Replying to chriscct7:

HTML shouldn't be inside a localized string as it doesn't need to be translated. See HTML section on ​http://codex.wordpress.org/I18n_for_WordPress_Developers

upgrade-revised.php.diff​ is actually perfectly fine from a translator's point of view, and appears to using an existing string​. Codex links can be translated as well, so that section does not apply here.

My concern with the patch is that database upgrades are generally safe and not intensive, so the additional reminder is probably not needed.

See comment:5:ticket:7965, which suggests removing the extra database update step in single site.

Thanks for the feedback. That makes sense, not sure what to do, I suppose we could just close up this ticket then if it seems that it REALLY isn't needed at this point.

[wonderboymusic]

comment:7