WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#29787 closed defect (bug) (fixed)

Keyboard focus on the header settings screens (Twentyfourteen)

Reported by: florianziegler Owned by: lancewillett
Milestone: 4.1 Priority: normal
Severity: normal Version: 4.1
Component: Bundled Theme Keywords: has-patch
Focuses: accessibility Cc:
PR Number:

Description

This relates to ticket #29289

"On the 'Appearance -> Header' screen, there is an oddity when using the keyboard to tab around.
The site title in the header preview is focusable, but it shouldn't be."

Turns out that themes overwrite the custom-header.php file, where this "bug" also exists, so it has to be patched individually.

Attachments (1)

29787.diff (949 bytes) - added by florianziegler 5 years ago.

Download all attachments as: .zip

Change History (6)

@florianziegler
5 years ago

#1 @florianziegler
5 years ago

  • Keywords dev-feedback needs-testing has-patch added

#2 @obenland
5 years ago

  • Component changed from Themes to Bundled Theme
  • Focuses administration removed

#3 @joedolson
5 years ago

  • Keywords dev-feedback needs-testing removed

I agree; this is a good change. Tested, works.

#4 @lancewillett
5 years ago

  • Milestone changed from Awaiting Review to 4.1

#5 @lancewillett
5 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 30146:

Twenty Fourteen: fix keyboard focus on Appearance > Header view.

Props florianziegler, fixes #29787.

Note: See TracTickets for help on using tickets.