Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #29792, comment 52


Ignore:
Timestamp:
10/13/2015 10:54:50 AM (11 years ago)
Author:
netweb
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #29792, comment 52

    initial v1  
    2828We can do the same to both allow and disallow whitespace by not defining the `function-parentheses-space-inside` rule.
    2929
    30 This is indeed the case in why the `media-query-parentheses-space-inside` rule ([https://github.com/stylelint/stylelint/blob/master/src/rules/media-query-parentheses-space-inside/README.md definition]) has not been defined in the current `stylelint-config-wordpress` ruleset as Nacin had explicitly created a pull request to allow with and without whitespace in media queries and I was not going to define that rule because that decision had already been made in this ticket ;)
     30~~This is indeed the case in why the `media-query-parentheses-space-inside` rule ([https://github.com/stylelint/stylelint/blob/master/src/rules/media-query-parentheses-space-inside/README.md definition]) has not been defined in the current `stylelint-config-wordpress` ruleset as Nacin had explicitly created a pull request to allow with and without whitespace in media queries and I was not going to define that rule because that decision had already been made in this ticket ;)~~
     31
     32EDIT: My bad, turns out indeed `media-query-parentheses-space-inside` is currently defined as `never` i.e `"media-query-parentheses-space-inside": [ 2, "never" ],`, rule definition [https://github.com/stylelint/stylelint/blob/master/src/rules/media-query-parentheses-space-inside/README.md here]
     33
     34Stats: To change our CSS to include this whitespace will be 262 changes or 74 changes to remove the white space in these media queries
     35