unified theme and plugin uploader

[svenl77]

Hi,

many users try to install plugins as themes and than they get a message stylesheet missing.

"The theme is missing the style.css stylesheet"

The same with installing themes as plugins.

"The package could not be installed. No valid plugins were found."

I think it would make it much easier for the people to make the upload unified and check the header to find out if its a theme or plugin and than just redirect to the correct page after the instal.

Or at least add a message "This is a plugin please go to this page to install it" and "This is a Theme please go to this page to install it"

[DrewAPicture]

There is some discussion going on to improve at least the plugin installation process in 4.1. I don't think we'll be combining the workflows any time soon.

[mattyza]

Perhaps a lean solution to mitigate this issue would be to educate the user when they upload to the correct form.

While we could certainly take care of the upload correctly for them in the background (calling the theme uploader if we detect a theme in the plugins uploader, for example), this doesn't help to educate the user about what they've done incorrectly (so they'll learn the incorrect behaviour and just repeat it, because it gets the results they desire).

Perhaps a simple tweak to the error response messages, directing the user to the correct form, is a simple solution which can be forward-compatible as well.

cc @DrewAPicture @svenl77

[mattyza]

First pass at adding detection, and notices, if a theme is uploaded to the plugins uploader and visa versa.

[mattyza]

For what it's worth, I attempted linking to the theme and plugin installers respectively, yet WP_Error strips out the HTML.

[desrosj]

Replying to DrewAPicture:

I don't think we'll be combining the workflows any time soon.

This is still accurate today. However, I think that adding an error message for the user informing them that they're in the wrong location is a reasonable change.