Opened 10 years ago
Closed 10 years ago
#29824 closed defect (bug) (fixed)
Correct context for strings on taxonomy screens
Reported by: | SergeyBiryukov | Owned by: | andg |
---|---|---|---|
Milestone: | 4.1 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Taxonomy | Keywords: | good-first-bug has-patch |
Focuses: | Cc: |
Description
We have four strings on taxonomy screens (see [29803] for reference):
_ex( 'Name', 'Taxonomy Name' ) _ex( 'Slug', 'Taxonomy Slug' ) _ex( 'Parent', 'Taxonomy Parent' ) _ex( 'Description', 'Taxonomy Description' )
'Taxonomy Name'
should be'term name'
, see WP_Terms_List_Table::get_columns().- In the other three strings, the context can probably be removed, since we don't have in the list table, and it appears to be redundant. Originally introduced in [13077].
Attachments (1)
Change History (9)
#1
follow-up:
↓ 4
@
10 years ago
- Keywords has-patch added; needs-patch removed
- Owner set to andg
- Status changed from new to assigned
#2
@
10 years ago
Apparently 'Parent'
still needs a context, some languages translate it differently for terms and pages.
#4
in reply to:
↑ 1
@
10 years ago
Replying to SergeyBiryukov:
Hi andg, thanks for the patch! Just a note, attachments don't trigger email notifications, so it's a good idea to leave a comment whenever you upload something.
Noted, thanks! ;)
#5
follow-up:
↓ 6
@
10 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
I'd rather leave the context on these existing strings, no? Otherwise we're just breaking them for no apparent reason, and we may well need to add context back in the future. It's also possible that they need to know the situation in which it is used in order to translate it (which would be suitable as a description if the string doesn't need to be split, but context is also fine).
#6
in reply to:
↑ 5
@
10 years ago
Replying to nacin:
I'd rather leave the context on these existing strings, no? Otherwise we're just breaking them for no apparent reason, and we may well need to add context back in the future.
We're actually merging them with the strings used in the list table.
Unlike "Parent", which can be translated differently for taxonomies and post types, "Slug" appears to be a universal term. I'm fine with adding the context for it back, but it should be done in the list table as well, and the lack of it there was not reported before.
"Description" does not look like it needs a special context.
Hi andg, thanks for the patch! Just a note, attachments don't trigger email notifications, so it's a good idea to leave a comment whenever you upload something.