Changes between Initial Version and Version 1 of Ticket #29839, comment 31
- Timestamp:
- 11/15/2014 09:01:19 PM (11 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #29839, comment 31
initial v1 6 6 > * You got the right place for the docblock :) I don't think it's correct to say that 'childless' is the opposite of 'parent', because 'parent' takes a term ID and returns only children of the parent, while 'childless' doesn't care what part of the taxonomy tree you're in and takes a boolean argument. 7 7 8 The results are opposite though, which is what I was referring to. I'll remove the assertion though just for clarity's sake.8 I'll remove it for sure. I had a misunderstanding in my head on what `parent` did. 9 9 10 10 > * You bail out of the function with an empty array if the taxonomy hierarchy is empty. Why? (This is kind of a trick question: a couple other parameters do this, and it's not totally obvious why they do it either.) If it's intended to save database queries, or prevent false positives, or whatever, it would be nice to see a unit test that demonstrates it. Alternatively, if that block doesn't affect anything, we should tear it out.