term_exists gives back the wrong term when it has parents

[allaerd]

when i have this terms

server->hp->ram

and i call

term_exists( 'hp' , 'product_cat', 0);

i expect to get back false

when i have this

hp->ram

i expect to get back a positive result

[boonebgorges]

Confirmed. The problem is that passing a parent of 0 causes the parent clause to be bypassed. That means that there is no way to use term_exists() and filter by top-level terms.

29851.patch​ contains a unit test demonstrating the problem, as well as a suggested fix. In brief: change the default value of $parent from 0 to null, and build the parent SQL clause whenever the value of $parent is numeric. Use of term_exists() with no parent param will remain the same, as will its use when passing a non-zero integer. It fixes this bug (passing a 0 or '0' is now interpreted correctly).

allaerd, is it possible for you to test this change to see if it solves your problem?

[allaerd]

Hi boonebgorges

i tested the solution and it now works as expected!

Thanks and regards,

Allaerd

[boonebgorges]

Thanks for the confirmation, allaerd.

[boonebgorges]

In 29863:

Fix term_exists() for parent = 0.

Passing a 0 (or '0') as the 'parent' param of term_exists() should limit
results to terms with no parent.

Adds unit test.

Fixes #29851.

[nacin]

[29863] looks good.