Pass $size to wp_get_attachment_image_attributes filter

[mattheu]

It would be useful to have access to the originally requested image size in the wp_get_attachment_image_attributes filter.

Use case: the srcset attribute has recently been introduced - and is useful for adding 2x (3x etc) high res images for devices with high res screens. If plugins were able to access the size in this filter, it could be used to add this.

Somewhat related - but not the same: #14110

[SergeyBiryukov]

$size cannot be an array at that point, see line 702​.

Should we pass that 1024x768-like string to the filter, or the original requested array?

[DrewAPicture]

Replying to SergeyBiryukov:

$size cannot be an array at that point, see line 702​.

Should we pass that 1024x768-like string to the filter, or the original requested array?

I vote we store the value of $size before it's (maybe) modified and pass that to the filter.

[mattheu]

Pass original size not value modified for use in class

[mattheu]

Updated patch - instead of storing the original value of size I've used a $size_class variable as I think its a little neater.

[SergeyBiryukov]

In 29836:

Pass the requested size to 'wp_get_attachment_image_attributes' filter.

props mattheu.
fixes #29869.

[SergeyBiryukov]

In 29837:

Update @param docs for wp_get_attachment_image().

see #29869.