Pagination disappears after deleting the last page of post entries

[Greg Raven]

If you have multiple pages of posts listed in the All Posts listing, go to the last page of the posts. Click the checkbox to select all of the posts on that page. Bulk delete your selection. After WP deletes those entries, the pagination disappears from the top of the listing pane.

If you delete all posts from other pages, when the window content refreshes the pagination will be there.

[helen]

Thanks for the report, sorry we missed this. Seems like we should check to make sure we're within the bounds of pagination and, if not, go to the last page.

[A5hleyRich]

This can be replicated by just appending the paged parameter with a page number greater than the total pages on the all posts screen.

[SergeyBiryukov]

Previously: #16208, #16357.

[helen]

Should look into why what's in WP_List_Table doesn't seem to work.

[A5hleyRich]

I'm not sure WP_List_Table is at fault here, the issue is that the prepare_items method in the WP_Posts_List_Table class is not passing the correct values.

The reason for querying for the post counts separately is for performance reasons. The initial query doesn't return results because the SQL offset exceeds the amount of posts, but removing the offset will query and return all posts on every paginated page, hence the additional lookup.

[pirasath]

Thanks for the patch i tried it work.

[wonderboymusic]

In 34271:

Posts List Table: Use a more robust technique for calculating $total_items so that pagination still appears when items are removed on the last page of results and ->max_num_pages decreases.

Props A5hleyRich.
Fixes #29870.

[ocean90]

[34271] brokes the pagination for searches. It uses the total number of posts and not the number of search results.

[DrewAPicture]

@wonderboymusic Sounds like we need a follow-up re: comment:12.

[wonderboymusic]

In 35622:

List Tables: after [34271], account for searches when calculating pagination.

Fixes #29870.

[bradyvercher]

I ran into issues with this earlier today where the pagination no longer works with custom views that modify the query. The total items count used to be calculated based on $wp_query->found_posts, so pagination correctly accounted for any changes to the query, but that's no longer the case.

It tried to find a way to fix the pagination args from outside the list table, but it doesn't look like it's possible after [34271].

[bradyvercher]

I attached a new patch that continues using $wp_query->found_posts on the first page of results or when any posts are actually found, otherwise it'll use the post counts to determine if the request is out of bounds.

I also went ahead and removed the $total_pages calculation since that's done immediately in WP_List_Table::set_pagination_args().

[wonderboymusic]

In 35683:

List Tables: After [35622] and [34271], improve pagination logic when queries are altered.

Props bradyvercher.
Fixes #29870.