Make WordPress Core

Opened 16 years ago

Closed 16 years ago

Last modified 15 years ago

#2988 closed defect (bug) (fixed)

Suspected fread data loss bug in class-snoopy.php fix

Reported by: cschneid's profile cschneid Owned by:
Milestone: Priority: normal
Severity: normal Version: 2.0.4
Component: Administration Keywords:
Focuses: Cc:

Description

I think the following should be done on line 1241 in wp-includes/class-snoopy.php:

 while (!feof($fp)) {
-  $file_content = fread($fp, filesize($file_name)); 
+  $file_content .= fread($fp, filesize($file_name)); 
 } 

i.e. concatenate the read data instead of just using the last part.

Change History (5)

#1 @ryan
16 years ago

  • Milestone set to 2.1
  • Version set to 2.0.4

Right you are. Luckily, traversing the loop more than once should be rare.

#2 @ryan
16 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [4075]) Don't forget to concat. Props cschneid. fixes #2988

#3 @ryan
16 years ago

(In [4222]) Don't forget to concat. Props cschneid. fixes #2988

#4 @foolswisdom
16 years ago

  • Milestone changed from 2.1 to 2.0.5

#5 @(none)
15 years ago

  • Milestone 2.0.5 deleted

Milestone 2.0.5 deleted

Note: See TracTickets for help on using tickets.