wptexturize: quotes inside quotes curling incorrectly

[iseulde]

I've been looking through Trac a bit, but couldn't find a ticket reporting this problem.

When you use quotes inside quotes, this happens:

bad: ‘”…” …’

bad: ‘… “…”‘

good: “‘…’ …”

bad: “… ‘…'”

[iseulde]

It looks like the last case was introduced in 3.9, so single quotes inside double quotes were OK before 3.9.

[iseulde]

Hm, three quotes in a row break in all four cases.

[miqrogroove]

Hi Avryl, could you provide one or two example sentences for each case?

[iseulde]

Let me try to make some unit tests. :-)

[iseulde]

My first unit tests. :) Please tell me if I'm doing something wrong.

[iseulde]

So the first one passes. The second one fails, but passed in 3.8. The last two never passed.

[miqrogroove]

For clarity, these are avryl's tests:

She said, "'I'm tired,' he mumbled."
She said, "He mumbled, 'I'm tired.'"
He said, '"I'm tired," she mumbled.'
He said, 'She mumbled, "I'm tired."'

[gitlost]

Extra pass for embedded quotes.

[gitlost]

Refresh/expansion of @iseulde test patch for 4.4.

[gitlost]

Patch that adds an extra pass for embedded quotes. One incompatibility shown up by unit tests - "word\"' word word" becomes two closing quotes rather than closing quote, then opening quote.