WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #29885, comment 15


Ignore:
Timestamp:
10/08/2014 02:40:34 PM (5 years ago)
Author:
chriscct7
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #29885, comment 15

    initial v1  
    11Hi Boone,
    2 I by not any means intended to suggest to discard the existing patch. I'm actually a really big fan of what it does. I just wanted to point out that while its really useful it wasn't the intended goal of the ticket, and suggested we instead append to it so we get both the intended functionality of the ticket and the functionality in the patch. I don't really care as to how its implemented, but somehow, we need to add the ability to be able to get all comments that aren't written by a specific author or array of authors.
     2I by no any means intended to suggest to discard the existing patch. I'm actually a really big fan of what it does. I just wanted to point out that while its really useful it wasn't the intended goal of the ticket, and suggested we instead append to it so we get both the intended functionality of the ticket and the functionality in the patch. I don't really care as to how its implemented, but somehow, we need to add the ability to be able to get all comments that aren't written by a specific author or array of authors.
    33
    44While the goal is to parallel WP_Query, it should be noted that the author parameters always correspond to the author of the given data, in the normal case a post. On one hand while I get how `author__not_in` referring to the comment author, might be confusing, at the end of the day the author parameters always point to the data, not what its displayed on. Its the way that most developers will end up expecting comment querying to work, and actually the whole reason I opened this ticket, was because I mistakenly assumed `author__not_in` already was an existing parameter for comment queries and had pushed code assuming it was. While my mistake alone shouldn't be contrived to be a barometer of sorts for the developer community at whole by a long shot, I think its safe to assume when someone sees the author parameter in WP_Query and interprets it to be the author of the post, they'll see the same parameter for comment querying as the author of the comment. It could also be implemented as proposed above using a `comment_author__not_in` name.