WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#29895 closed defect (bug) (fixed)

Avoid empty markup in comments

Reported by: obenland Owned by: ocean90
Milestone: 4.1 Priority: normal
Severity: normal Version: 2.7
Component: Comments Keywords: has-patch twenty-fifteen
Focuses: template Cc:

Description

When comment_reply_link() doesn't display a link, like when comments are closed, both Walker_Comment::comment() and Walker_Comment::html5_comment() still display the empty wrapper div.

This can lead to design irregularities when margins or paddings are applied to that element, but shouldn't since the link to pad is non-existent.

Attachments (1)

29895.diff (1.4 KB) - added by obenland 5 years ago.

Download all attachments as: .zip

Change History (6)

@obenland
5 years ago

#1 @obenland
5 years ago

  • Keywords twenty-fifteen added

Tagging with twenty-fifteen to keep track of it.

#2 @Frank Klein
5 years ago

Tested the patch, looks good to me.

#3 @SergeyBiryukov
5 years ago

  • Component changed from General to Comments
  • Focuses template added
  • Milestone changed from Awaiting Review to 4.1

#4 @ocean90
5 years ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 29908:

Comments: Don't print an empty HTML markup when comment_reply_link() returns no link.

props obenland.
fixes #29895.

#5 @helen
5 years ago

#25203 was marked as a duplicate.

Note: See TracTickets for help on using tickets.