WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#29921 closed defect (bug) (fixed)

missing label for categories select in posts list table

Reported by: afercia Owned by: SergeyBiryukov
Milestone: 4.1 Priority: normal
Severity: normal Version: 4.0
Component: Posts, Post Types Keywords: has-patch
Focuses: ui, accessibility Cc:

Description

Missing label for the categories select in the posts list table.
Please notice this is different from #18650 which is about widgets, while this ticket is about the admin UI.
See screenshot below, before and after, where I've temporary made the hidden screen reader text visible.

https://cldup.com/u3hHb2VIjV.png

Proposed patch just adds an implicit label in class-wp-posts-list-table.php and changes the first option text 'View all categories' in 'All categories' for consistency.

Attachments (1)

29921.patch (852 bytes) - added by afercia 5 years ago.

Download all attachments as: .zip

Change History (6)

@afercia
5 years ago

#1 @afercia
5 years ago

  • Keywords has-patch added

#2 @SergeyBiryukov
5 years ago

  • Milestone changed from Awaiting Review to 4.1

#3 @SergeyBiryukov
5 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 29870:

Add missing labels to category filter dropdowns.

props afercia.
fixes #29921.

#4 @SergeyBiryukov
5 years ago

In 29871:

Remove "View" prefix from category filter dropdowns, for consistency with [27626].

props afercia.
see #29921.

#5 @afercia
5 years ago

Sergey thx for reviewing also class-wp-links-list-table.php, I missed that :)

Note: See TracTickets for help on using tickets.