WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 2 months ago

Last modified 2 months ago

#29932 closed enhancement (invalid)

There is no error reporting in the Customizer (for upload failures)

Reported by: Fab1en Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.4
Component: Customize Keywords: needs-patch
Focuses: javascript, administration Cc:

Description (last modified by westonruter)

As far as I know, there is no way to display an error to the user when he/she is using the theme customizer.

An error that I'm facing some time to time when I test WordPress locally is when wp-content/uploads is not writable. Then, uploading a new image to use as a background in the customizer does not work, but this fails silently.

This error reporting should be built-in inside WP_Customize_Control class so that any control that extends this class can throws a custom error and displays it to the user.

Depends on #35210.

Change History (21)

#1 @DrewAPicture
3 years ago

  • Focuses javascript added
  • Summary changed from There is no error reporting in the cistomizer to There is no error reporting in the Customizer

#2 @westonruter
3 years ago

This is related to #29098, which would provide the general mechanism for sending back error codes/messages.

#3 @boonebgorges
2 years ago

  • Version changed from trunk to 3.4

#4 @westonruter
2 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to Future Release

It looks like #29098 may not be exactly what we need to communicate upload errors back to the Customizer. Instead of sending error messages back when customize_save happens, the actual upload error is going to happen when the setting is updated and the value gets synced with the Customizer preview.

#5 @westonruter
16 months ago

  • Description modified (diff)
  • Milestone changed from Future Release to 4.5

To work on as part of implementing the notification area (#35210).

See also:

  • #31582: Catching PHP Fatal Errors on WordPress Theme Customizer
  • #34893: Improve Customizer setting validation model

This ticket was mentioned in Slack in #core by westonruter. View the logs.


16 months ago

#7 @chriscct7
14 months ago

  • Milestone changed from 4.5 to Future Release

Punting to next release per discussion with @westonruter

#8 @westonruter
13 months ago

  • Milestone changed from Future Release to 4.6

This ticket was mentioned in Slack in #core-customize by celloexpressions. View the logs.


12 months ago

#10 @westonruter
12 months ago

It seems the error being described here would make the most sense to display in the same location where error messages are displayed for setting validation (#34893). As such, the control API for error messages should be agnostic to whether it is a validation error or some other error message.

This ticket was mentioned in Slack in #design by westonruter. View the logs.


11 months ago

#12 @westonruter
11 months ago

  • Milestone changed from 4.6 to Future Release

Punting due to transactions being too large to finish patch and test in time for 4.6.

#13 @westonruter
9 months ago

  • Milestone changed from Future Release to 4.7

This ticket was mentioned in Slack in #core by jorbin. View the logs.


8 months ago

This ticket was mentioned in Slack in #core-customize by celloexpressions. View the logs.


7 months ago

#16 @celloexpressions
7 months ago

  • Owner set to westonrtuer
  • Status changed from new to assigned

#17 @celloexpressions
7 months ago

  • Owner changed from westonrtuer to westonruter

#18 @westonruter
7 months ago

  • Keywords reporter-feedback added
  • Milestone changed from 4.7 to Awaiting Review
  • Owner westonruter deleted
  • Summary changed from There is no error reporting in the Customizer to There is no error reporting in the Customizer (for upload failures)

I believe that his is now irrelevant because the upload control now extends the media control as of #29215 (in 4.2) and the media library will show an error message when an upload fails in the modal. @Fab1en can you confirm?

Otherwise, the notifications API added in 4.6 as part of the setting validation improvements (#34893) provides the framework for controls to add notifications for errors, warnings, and informational messages.

This ticket was mentioned in Slack in #core-customize by westonruter. View the logs.


2 months ago

#20 @westonruter
2 months ago

  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from assigned to closed

#21 @Fab1en
2 months ago

  • Keywords reporter-feedback removed

Sorry for the late answer @westonruter, but I confirm that this issue is now irrelevant in WP 4.7. An error message is now displayed when a file cannot be uploaded during a customizer session.

Note: See TracTickets for help on using tickets.