#29932 closed enhancement (invalid)
There is no error reporting in the Customizer (for upload failures)
Reported by: | Fab1en | Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | 3.4 |
Component: | Customize | Keywords: | needs-patch |
Focuses: | javascript, administration | Cc: |
Description (last modified by )
As far as I know, there is no way to display an error to the user when he/she is using the theme customizer.
An error that I'm facing some time to time when I test WordPress locally is when wp-content/uploads
is not writable. Then, uploading a new image to use as a background in the customizer does not work, but this fails silently.
This error reporting should be built-in inside WP_Customize_Control
class so that any control that extends this class can throws a custom error and displays it to the user.
Depends on #35210.
Change History (21)
#1
@
10 years ago
- Focuses javascript added
- Summary changed from There is no error reporting in the cistomizer to There is no error reporting in the Customizer
#4
@
10 years ago
- Keywords needs-patch added
- Milestone changed from Awaiting Review to Future Release
It looks like #29098 may not be exactly what we need to communicate upload errors back to the Customizer. Instead of sending error messages back when customize_save
happens, the actual upload error is going to happen when the setting is updated and the value gets synced with the Customizer preview.
This ticket was mentioned in Slack in #core by westonruter. View the logs.
9 years ago
#7
@
9 years ago
- Milestone changed from 4.5 to Future Release
Punting to next release per discussion with @westonruter
This ticket was mentioned in Slack in #core-customize by celloexpressions. View the logs.
9 years ago
#10
@
9 years ago
It seems the error being described here would make the most sense to display in the same location where error messages are displayed for setting validation (#34893). As such, the control API for error messages should be agnostic to whether it is a validation error or some other error message.
This ticket was mentioned in Slack in #design by westonruter. View the logs.
9 years ago
#12
@
9 years ago
- Milestone changed from 4.6 to Future Release
Punting due to transactions being too large to finish patch and test in time for 4.6.
This ticket was mentioned in Slack in #core by jorbin. View the logs.
8 years ago
This ticket was mentioned in Slack in #core-customize by celloexpressions. View the logs.
8 years ago
#18
@
8 years ago
- Keywords reporter-feedback added
- Milestone changed from 4.7 to Awaiting Review
- Owner westonruter deleted
- Summary changed from There is no error reporting in the Customizer to There is no error reporting in the Customizer (for upload failures)
I believe that his is now irrelevant because the upload control now extends the media control as of #29215 (in 4.2) and the media library will show an error message when an upload fails in the modal. @Fab1en can you confirm?
Otherwise, the notifications API added in 4.6 as part of the setting validation improvements (#34893) provides the framework for controls to add notifications for errors, warnings, and informational messages.
This is related to #29098, which would provide the general mechanism for sending back error codes/messages.