WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#29934 closed defect (bug) (fixed)

Media modal: make the "Selected" row (at the bottom) thumbnails non-draggable

Reported by: azaozz Owned by: johnbillion
Milestone: 4.1 Priority: normal
Severity: normal Version:
Component: Media Keywords: has-patch 2nd-opinion
Focuses: Cc:

Description

Continuing from https://core.trac.wordpress.org/ticket/29606#comment:15, the small thumbnails that show in the "Selected" row at the bottom while selecting images for a gallery are currently draggable. This doesn't seem particularly usable as they are draggable only while selecting images for a new gallery and only the first few are shown (depending on the window width).

Attachments (3)

29934.patch (462 bytes) - added by jessepollak 6 years ago.
29934.patch
Screenshot_2014-10-26_11_38_36.png (306.6 KB) - added by jessepollak 6 years ago.
Multiple images selected in original order
Screenshot_2014-10-26_11_38_48.png (306.4 KB) - added by jessepollak 6 years ago.
Multiple images selected in rearranged order

Download all attachments as: .zip

Change History (8)

@jessepollak
6 years ago

29934.patch

@jessepollak
6 years ago

Multiple images selected in original order

@jessepollak
6 years ago

Multiple images selected in rearranged order

#2 @jessepollak
6 years ago

Dug into this one and I've attached a patch that makes the "Selected" row at the bottom non-draggable.

That said, this restricts functionality for the use case where I want to insert multiple images into a post in a certain order. Without the patch I can (see screenshots above):

  1. Select the multiple images I want to insert.
  2. Drag the Selected images at the bottom to the order I want to insert in.

With the patch, I can't do step (2), so I'll need to reorder the images after I insert them (which is OK, but not great).

Thoughts on how we'd like to proceed?

#3 @jessepollak
6 years ago

  • Keywords has-patch 2nd-opinion added

This ticket was mentioned in Slack in #core by jessepollak. View the logs.


6 years ago

#5 @johnbillion
6 years ago

  • Owner set to johnbillion
  • Resolution set to fixed
  • Status changed from new to closed

In 30686:

Remove the sortable functionality from the selection editing toolbar at the bottom of the media manager.

Fixes #29934
See #24352
Props jessepollak

Note: See TracTickets for help on using tickets.