Context Navigation

← Previous Ticket
Next Ticket →

#29944 closed defect (bug) (fixed)

When editing a long post in Text mode, clicking on any of the Quicktags buttons may auto-scroll the page

Reported by:	azaozz	Owned by:	nacin
Priority:	normal	Milestone:	4.0.1
Component:	Editor	Version:	4.0
Severity:	normal	Keywords:	fixed-major commit
Cc:		Focuses:

Description

Happens only in Chrome 38 (recently released) when editor expand is enabled, and only when the caret is somewhere in the middle of the post.

Attachments (1)

29944.diff (848 bytes ) - added by jorbin 12 years ago.

Download all attachments as: .zip

Change History (10)

#1 @iseulde
12 years ago

Looks like this is a Chrome bug. Happens too with editor expand disabled, if you make the textarea a bit longer.

#2 @azaozz
12 years ago

Yeah, can reproduce it without editor expand too.

#3 @azaozz
12 years ago

After some quick debugging with @avryl, caused by canvas.focus(); before setting the new caret position (canvas.selectionStart and canvas.selectionEnd).

#4 @azaozz
12 years ago

Keywords fixed-major commit added

In [29884]:

Quicktags: move focusing the editor after inserting content to the end of the code blocks. Fixes a bug in Chrome where both the textarea and the window may auto-scroll to unexpected position on clicking a Quicktags button. Part props avryl, fixes #29944 for trunk.

#5 @SergeyBiryukov
12 years ago

Summary When editing a long post in Text more, clicking on any of the Quicktags buttons may auto-scroll the page → When editing a long post in Text mode, clicking on any of the Quicktags buttons may auto-scroll the page

#6 @krotz
12 years ago

#30004 was marked as a duplicate.

#7 @hernangonzalez
12 years ago

#30140 was marked as a duplicate.

@jorbin
12 years ago

Attachment 29944.diff added

#8 @jorbin
12 years ago

I've tested in chrome 38 and chrome 40.

The above patch ports the change in r29884 over to the 4.0 branch and is ready to be merged.

#9 @nacin
12 years ago

Owner set to nacin
Resolution → fixed
Status new → closed

In 30250:

Quicktags: move focusing the editor after inserting content to the end of the code blocks.

Merges [29884] to the 4.0 branch.

Fixes a bug in Chrome where both the textarea and the window may auto-scroll to unexpected position on clicking a Quicktags button.

props azaozz, avryl.
fixes #29944.

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#29944 closed defect (bug) (fixed)

When editing a long post in Text mode, clicking on any of the Quicktags buttons may auto-scroll the page

Description

Attachments (1)

Change History (10)

#1 @iseulde 12 years ago

#2 @azaozz 12 years ago

#3 @azaozz 12 years ago

#4 @azaozz 12 years ago

#5 @SergeyBiryukov 12 years ago

#6 @krotz 12 years ago

#7 @hernangonzalez 12 years ago

@jorbin 12 years ago

#8 @jorbin 12 years ago

#9 @nacin 12 years ago