WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#29947 closed defect (bug) (fixed)

Reference to "Theme Customizer" in Customizer screen reader text

Reported by: celloexpressions Owned by: studionashvegas
Milestone: 4.1 Priority: normal
Severity: minor Version: 4.0
Component: Customize Keywords: good-first-bug has-patch needs-testing commit
Focuses: accessibility Cc:

Description

We're moving away from the term "Theme Customizer" in favor of just "Customizer". We missed an instance of "Theme Customizer" in the aria-label attribute of the #customize-info section at the top of the Customizer (which says "you are customizing..."); the "Theme" part should be removed.

Attachments (3)

29947-customize-patch.diff (1015 bytes) - added by studionashvegas 5 years ago.
29947 - removed instance of "Theme" from "Theme Customizer"
29947-customize-patch-v2.diff (1.1 KB) - added by studionashvegas 5 years ago.
Use this patch instead - I missed the "instance of Theme Customizer" in the commented section.
29947-customize-patch.2.diff (11.1 KB) - added by tareq1988 5 years ago.
This one has all the replacement of theme customizer

Download all attachments as: .zip

Change History (10)

@studionashvegas
5 years ago

29947 - removed instance of "Theme" from "Theme Customizer"

#1 @studionashvegas
5 years ago

  • Keywords has-patch added; needs-patch removed

@studionashvegas
5 years ago

Use this patch instead - I missed the "instance of Theme Customizer" in the commented section.

#2 @studionashvegas
5 years ago

  • Keywords needs-testing added

#3 @DrewAPicture
5 years ago

  • Milestone changed from Future Release to 4.1
  • Owner set to studionashvegas
  • Status changed from new to assigned

#4 @celloexpressions
5 years ago

  • Keywords commit added

Looks good, thanks @studionashvegas!

@tareq1988
5 years ago

This one has all the replacement of theme customizer

#6 @celloexpressions
5 years ago

Awesome, 29947-customize-patch.2.diff takes care of all instances including bundled themes. Technically we should also always be capitalizing "Customizer" everywhere, although that's not as important.

#7 @ocean90
5 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 29903:

Customizer: Change instances of "Theme Customizer" to just "Customizer", as the Customizer isn't necessarily theme-specific.

Also capitalize "Customizer".
See also https://make.wordpress.org/core/2014/07/08/customizer-improvements-in-4-0/.

props studionashvegas, tareq1988.
fixes #29947.

Note: See TracTickets for help on using tickets.