WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #29958, comment 22


Ignore:
Timestamp:
03/20/2015 12:34:29 PM (10 years ago)
Author:
valendesigns
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #29958, comment 22

    initial v1  
    1 I tested the previous patch and everything functionally works as expected using my keyboard. The only real issue was that it didn't properly support color schemes and the focus state was persistent. Patch [attachment:29958.5.diff] solves both those issues. As well, I removed the screen reader text and now rely on JS to toggle the label using some strings I added to the `commonL10n1` object.
     1I tested the previous patch and everything functionally works as expected using my keyboard. The only real issue was that it didn't properly support color schemes and the focus state was persistent. Patch [attachment:29958.5.diff] solves both those issues. As well, I removed the screen reader text and now rely on JS to toggle the label using some strings I added to the `commonL10n` object.