Make WordPress Core

Opened 12 years ago

Closed 12 years ago

#29970 closed defect (bug) (fixed)

Twenty Fifteen: Readability issue with Reply button in dark color scheme

Reported by: NikV Owned by: iandstewart
Priority: normal Milestone: 4.1
Component: Bundled Theme Version: 4.1
Severity: normal Keywords: has-patch
Cc: Focuses:

Description

If we switch to the dark color scheme and go to a post and go to down to the comments, it's seems that it would be a bit hard to read the reply button, it seems very hidden. Here is how it looks like now:

​https://cloudup.com/cJDbwFD_0Hu (Before change)

But this is how it would most likely look like in a good light environment, but in a low light environment on a desktop or even a phone, it would be a little harder to read. I made a small tweak in the customizer.php file to fix this.

Here it is after a small tweak: ​https://cloudup.com/ceKvQhtKzJr

Notice the small tweak in the readability of the comment author text as well.

Attachments (2)

29970.diff​ (386 bytes ) - added by NikV 12 years ago.
29970-1.diff​ (482 bytes ) - added by NikV 12 years ago.

Download all attachments as: .zip

Change History (7)

#1 follow-up: @iamtakashi
12 years ago

A good catch!

Can you re-create the patch from the root, not from the theme?

See: ​https://make.wordpress.org/core/handbook/working-with-patches/patches-with-command-line/#creating-a-patch

Patches should be created from the root directory of your WordPress SVN install.

Thanks!

#2 in reply to: ↑ 1 @NikV
12 years ago

Replying to iamtakashi:

A good catch!

Can you re-create the patch from the root, not from the theme?

See: ​https://make.wordpress.org/core/handbook/working-with-patches/patches-with-command-line/#creating-a-patch

Patches should be created from the root directory of your WordPress SVN install.

Thanks!

I almost always forget to do that! But I think I got it now with my latest file.

#3 @NikV
12 years ago

  • Keywords has-patch added

#4 @iandstewart
12 years ago

  • Milestone Awaiting Review → 4.1

#5 @iandstewart
12 years ago

  • Owner set to iandstewart
  • Resolution → fixed
  • Status new → closed

In 29930:

Twenty Fifteen: readable comment details in the dark colour scheme.

Props NikV, fixes #29970.

Note: See TracTickets for help on using tickets.