WordPress.org
Get WordPress

Make WordPress Core

Opened 9 years ago

Closed 9 years ago

#29976 closed defect (bug) (fixed)

Twenty Fifteen: Dark Theme Sidebar: Drop Down Arrow and Widgets text contrast

Reported by: nhuja's profile nhuja Owned by: iandstewart's profile iandstewart
Milestone: 4.1 Priority: normal
Severity: normal Version: 4.1
Component: Bundled Theme Keywords: has-patch commit
Focuses: Cc:

Description

When in Tablet mode, the sidebar goes up, the drop down arrow, widget titles and widget text blended pretty well with the background color (Dark Theme). See attachment.

Attachments (5)

29976.patch​ (896 bytes) - added by nhuja 9 years ago.
widget-titles.jpg​ (28.7 KB) - added by nhuja 9 years ago.
dropdown-widgets.jpg​ (19.7 KB) - added by nhuja 9 years ago.
29976.1.diff​ (2.8 KB) - added by iamtakashi 9 years ago.
Fix color scheme specific styles in widget areas and main navigation.
29976.2.diff​ (2.8 KB) - added by iamtakashi 9 years ago.
Updated patch

Download all attachments as: .zip

Change History (15)

@nhuja
9 years ago

@nhuja
9 years ago

@nhuja
9 years ago

#1 @nhuja
9 years ago

  • Keywords has-patch needs-testing added

#2 @obenland
9 years ago

  • Component changed from Themes to Bundled Theme

@iamtakashi
9 years ago

Fix color scheme specific styles in widget areas and main navigation.

#3 @iamtakashi
9 years ago

Thanks for the report, nhuja. It was actually a little more complex to fix but I think I've fixed all cases with the above.

#4 @iandstewart
9 years ago

Let's review this after reviewing #29982

#5 @iandstewart
9 years ago

@iamtakashi Can you update the patch? It's a bit out of sync now.

@iamtakashi
9 years ago

Updated patch

#6 @iamtakashi
9 years ago

#30041 was marked as a duplicate.

#7 @DrewAPicture
9 years ago

#30041 was marked as a duplicate.

#8 @iandstewart
9 years ago

  • Keywords commit added; needs-testing removed

#9 @iandstewart
9 years ago

  • Milestone changed from Awaiting Review to 4.1

#10 @iandstewart
9 years ago

  • Owner set to iandstewart
  • Resolution set to fixed
  • Status changed from new to closed

In 29971:

Twenty Fifteen: correct styles for color schemes

Props iamtakashi, fixes #29976.

Note: See TracTickets for help on using tickets.