#29977 closed defect (bug) (fixed)
Hook doc for xmlrpc_element_limit filter
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 4.1 | Priority: | normal |
Severity: | normal | Version: | 4.0 |
Component: | XML-RPC | Keywords: | has-patch |
Focuses: | docs | Cc: |
Description
xmlrpc_element_limit filter in class-IXR.php in wp-includes is not documented. Attached diff file contains documentation for the hook.
Attachments (3)
Change History (9)
#2
follow-up:
↓ 3
@
10 years ago
- Keywords needs-patch added; has-patch removed
- Milestone changed from Awaiting Review to 4.1
- Owner set to DrewAPicture
- Status changed from new to reviewing
Hi ankit, thanks for the patch. Couple things:
- The docblock should align with hook line itself, currently it's indented quite a bit
- "The limit of elements" is a little ambiguous, maybe change that to something like "Filter the number of elements to parse in an XML-RPC response"
- The
@since
tag should use the 3-digit, x.x.x style for the version - There should be a period at the end of the
@param
description
#3
in reply to:
↑ 2
@
10 years ago
Replying to DrewAPicture:
Hi ankit, thanks for the patch. Couple things:
- The docblock should align with hook line itself, currently it's indented quite a bit
- "The limit of elements" is a little ambiguous, maybe change that to something like "Filter the number of elements to parse in an XML-RPC response"
- The
@since
tag should use the 3-digit, x.x.x style for the version- There should be a period at the end of the
@param
description
Thank you Drew, I have attached revised patch file with given points.
This ticket was mentioned in Slack in #core by wpgeeko. View the logs.
10 years ago
Note: See
TracTickets for help on using
tickets.
Documentation for xmlrpc_element_limit filter.