Opened 10 years ago
Closed 10 years ago
#29982 closed defect (bug) (fixed)
Twenty Fifteen: remove Color Scheme custom control
Reported by: | cainm | Owned by: | iandstewart |
---|---|---|---|
Milestone: | 4.1 | Priority: | normal |
Severity: | normal | Version: | 4.1 |
Component: | Bundled Theme | Keywords: | has-patch commit |
Focuses: | Cc: |
Description
Now that the Color Scheme control is just a select dropdown with some additional JS to update the other color controls, we can probably remove the custom control and enqueue the JS on customize_controls_enqueue_scripts
.
Related: #29959
Attachments (2)
Change History (12)
#2
follow-up:
↓ 3
@
10 years ago
+1. Please use "Customizer" instead of "Theme Customizer" in the code comments (and everywhere), but otherwsie 29982.diff looks good.
#3
in reply to:
↑ 2
;
follow-up:
↓ 4
@
10 years ago
Replying to celloexpressions:
+1. Please use "Customizer" instead of "Theme Customizer" in the code comments (and everywhere), but otherwsie 29982.diff looks good.
Will do. I was just following suit with the rest of the file. Should we open a ticket to clean up all the instances?
#4
in reply to:
↑ 3
@
10 years ago
Replying to cainm:
Replying to celloexpressions:
+1. Please use "Customizer" instead of "Theme Customizer" in the code comments (and everywhere), but otherwsie 29982.diff looks good.
Will do. I was just following suit with the rest of the file. Should we open a ticket to clean up all the instances?
Yes, if there are a lot of those in Twenty Fifteen, we should do a ticket like #29947 for the theme.
Remove Color Scheme custom control