WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#29982 closed defect (bug) (fixed)

Twenty Fifteen: remove Color Scheme custom control

Reported by: cainm Owned by: iandstewart
Milestone: 4.1 Priority: normal
Severity: normal Version: 4.1
Component: Bundled Theme Keywords: has-patch commit
Focuses: Cc:

Description

Now that the Color Scheme control is just a select dropdown with some additional JS to update the other color controls, we can probably remove the custom control and enqueue the JS on customize_controls_enqueue_scripts.

Related: #29959

Attachments (2)

29982.diff (7.8 KB) - added by cainm 7 years ago.
Remove Color Scheme custom control
29982.2.diff (7.7 KB) - added by cainm 7 years ago.

Download all attachments as: .zip

Change History (12)

@cainm
7 years ago

Remove Color Scheme custom control

#1 @cainm
7 years ago

  • Keywords has-patch added

#2 follow-up: @celloexpressions
7 years ago

+1. Please use "Customizer" instead of "Theme Customizer" in the code comments (and everywhere), but otherwsie 29982.diff looks good.

#3 in reply to: ↑ 2 ; follow-up: @cainm
7 years ago

Replying to celloexpressions:

+1. Please use "Customizer" instead of "Theme Customizer" in the code comments (and everywhere), but otherwsie 29982.diff looks good.

Will do. I was just following suit with the rest of the file. Should we open a ticket to clean up all the instances?

#4 in reply to: ↑ 3 @celloexpressions
7 years ago

Replying to cainm:

Replying to celloexpressions:

+1. Please use "Customizer" instead of "Theme Customizer" in the code comments (and everywhere), but otherwsie 29982.diff looks good.

Will do. I was just following suit with the rest of the file. Should we open a ticket to clean up all the instances?

Yes, if there are a lot of those in Twenty Fifteen, we should do a ticket like #29947 for the theme.

#5 @celloexpressions
7 years ago

Actually, latest patch on #29947 takes care of Twenty Fifteen also.

@cainm
7 years ago

#6 @cainm
7 years ago

Updated to switch instances of 'Theme Customizer' with 'Customizer' in 29981.2.diff

#7 @iamtakashi
7 years ago

Thanks cainm, the patch looks great.

Once this is committed we can close #29959.

#8 @iandstewart
7 years ago

  • Milestone changed from Awaiting Review to 4.1

#9 @iandstewart
7 years ago

  • Keywords commit added

#10 @iandstewart
7 years ago

  • Owner set to iandstewart
  • Resolution set to fixed
  • Status changed from new to closed

In 29944:

Twenty Fifteen: Removing unused custom color controls.

Props cainm, fixes #29982 and #29959.

Note: See TracTickets for help on using tickets.