Opened 12 years ago
Closed 12 years ago
#29982 closed defect (bug) (fixed)
Twenty Fifteen: remove Color Scheme custom control
| Reported by: | cainm | Owned by: | iandstewart |
|---|---|---|---|
| Priority: | normal | Milestone: | 4.1 |
| Component: | Bundled Theme | Version: | 4.1 |
| Severity: | normal | Keywords: | has-patch commit |
| Cc: | Focuses: |
Description
Now that the Color Scheme control is just a select dropdown with some additional JS to update the other color controls, we can probably remove the custom control and enqueue the JS on customize_controls_enqueue_scripts.
Related: #29959
Attachments (2)
Change History (12)
#2
follow-up:
↓ 3
@
12 years ago
+1. Please use "Customizer" instead of "Theme Customizer" in the code comments (and everywhere), but otherwsie 29982.diff looks good.
#3
in reply to: ↑ 2
;
follow-up:
↓ 4
@
12 years ago
Replying to celloexpressions:
+1. Please use "Customizer" instead of "Theme Customizer" in the code comments (and everywhere), but otherwsie 29982.diff looks good.
Will do. I was just following suit with the rest of the file. Should we open a ticket to clean up all the instances?
#4
in reply to: ↑ 3
@
12 years ago
Replying to cainm:
Replying to celloexpressions:
+1. Please use "Customizer" instead of "Theme Customizer" in the code comments (and everywhere), but otherwsie 29982.diff looks good.
Will do. I was just following suit with the rest of the file. Should we open a ticket to clean up all the instances?
Yes, if there are a lot of those in Twenty Fifteen, we should do a ticket like #29947 for the theme.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
Remove Color Scheme custom control