WordPress.org
Get WordPress

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#29983 closed enhancement (fixed)

Only POST dirty settings to Customizer preview to improve performance

Reported by: celloexpressions's profile celloexpressions Owned by: ocean90's profile ocean90
Milestone: 4.1 Priority: normal
Severity: normal Version: 3.4
Component: Customize Keywords: has-patch commit
Focuses: Cc:

Description

Moving off of #28580 so that we can retain that for history even if we decide not to fix it. Patch from @westonruter.

This is almost a bug as it probably should've happened like this from the beginning, and will cause significant performance improvements when we do things like Menus in the Customizer.

Attachments (2)

28580.diff​ (1.5 KB) - added by celloexpressions 10 years ago.
@westonruter's patch, not mine
29983.2.diff​ (959 bytes) - added by westonruter 10 years ago.
​https://github.com/xwpco/wordpress-develop/pull/41

Download all attachments as: .zip

Change History (12)

@celloexpressions
10 years ago

@westonruter's patch, not mine

#1 @celloexpressions
10 years ago

  • Component changed from Bundled Theme to Customize

oops

#2 @ocean90
10 years ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 29905:

Customizer: Only POST dirty settings to preview to improve performance.

props westonruter.
fixes #29983.

This ticket was mentioned in ​Slack in #core by scott. ​View the logs.
10 years ago

This ticket was mentioned in ​Slack in #core by dd32. ​View the logs.
10 years ago

#5 @westonruter
10 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

@westonruter
10 years ago

​https://github.com/xwpco/wordpress-develop/pull/41

#6 @westonruter
10 years ago

Newly added widgets would not appear in the preview unless you made some change to a field in a widget, to flag it as dirty. In 29983.2.diff​, mark newly created settings for widgets as dirty immediately so that you don't have to touch the title or some other field manually to make it start to show up in the preview.

This ticket was mentioned in ​Slack in #core by westonruter. ​View the logs.
10 years ago

#8 @westonruter
10 years ago

  • Keywords commit added

#9 @scottsousa
10 years ago

Fixed: Tested the newest diff and the newly added widgets are updated in the Previewer without the adjustment of widget settings.

#10 @ocean90
10 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 30104:

Customizer: Fix missing newly added widgets in the preview after [29905].

props westonruter.
fixes #29983.

Note: See TracTickets for help on using tickets.