WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#29991 closed defect (bug) (fixed)

Comment action links are quite cramped on small screens

Reported by: pento Owned by:
Milestone: 4.3 Priority: normal
Severity: minor Version:
Component: Comments Keywords: make-flow has-patch needs-testing
Focuses: ui, administration Cc:
PR Number:

Description

On mobile devices, the comment action links are quite small and cramped - it's pretty easy to mis-tap.

Attachments (9)

IMG_2900.png (79.9 KB) - added by pento 5 years ago.
29991.diff (3.9 KB) - added by bradt 5 years ago.
Screen Shot 2014-11-14 at 3.52.09 PM.png (83.9 KB) - added by bradt 5 years ago.
29991.2.diff (3.9 KB) - added by bradt 5 years ago.
29991.3.diff (1.5 KB) - added by coreymcollins 5 years ago.
All of the above fixes and added: Increased line-height of .row-actions for comments on single post; fixed typo on .fixed .column-comment .comment-post-link (awhite-space -> white-space)
29991.4.diff (3.7 KB) - added by coreymcollins 5 years ago.
All of the above fixes and: fixing my diff. Accidentally created it while in the /css/ directory, so it was missing the additional changes.
29991.5.diff (2.3 KB) - added by gregrickaby 5 years ago.
Fixes "undefined variable" errors
29991.6.diff (4.0 KB) - added by bradt 5 years ago.
Previous patch was missing CSS.
IMG_4348.PNG (277.5 KB) - added by ryan 4 years ago.
Comment action links now have room

Download all attachments as: .zip

Change History (24)

@pento
5 years ago

#1 @soficgr
5 years ago

  • Severity changed from normal to minor

#2 @bradt
5 years ago

Working on a patch to hide the "In Response To" column.

@bradt
5 years ago

#3 @bradt
5 years ago

  • Keywords has-patch added

When screen is < 782px wide, it now:

  • Adds more spacing between the action links so that it's harder to tap the wrong one
  • Hides the "In Response To" column
  • Unhides a new "In Reponse To" section in the comment column

I've removed the "View Post" link as it didn't really fit well here.

@bradt
5 years ago

#4 @bradt
5 years ago

  • Keywords needs-testing added

Revised patch. Styles were unintentionally affecting action links in the entire dashboard instead of just the comments list table.

@coreymcollins
5 years ago

All of the above fixes and added: Increased line-height of .row-actions for comments on single post; fixed typo on .fixed .column-comment .comment-post-link (awhite-space -> white-space)

@coreymcollins
5 years ago

All of the above fixes and: fixing my diff. Accidentally created it while in the /css/ directory, so it was missing the additional changes.

@gregrickaby
5 years ago

Fixes "undefined variable" errors

@bradt
5 years ago

Previous patch was missing CSS.

#5 @bradt
5 years ago

Still applies cleanly against trunk. No need for a refresh.

#6 @SergeyBiryukov
5 years ago

  • Milestone changed from Awaiting Review to 4.2

Moving for review along with #29992 and #29993.

This ticket was mentioned in Slack in #core-flow by boren. View the logs.


5 years ago

#9 follow-up: @bradt
5 years ago

Just read the Slack convo from 3 weeks ago. So is the concensus to go ahead with an implementation like @helen's screenshot? http://cl.ly/3F1L0N3z1M0F0Z3t0X3W

Last edited 5 years ago by bradt (previous) (diff)

#10 @DrewAPicture
5 years ago

  • Priority changed from normal to high

#11 in reply to: ↑ 9 @ryan
5 years ago

Replying to bradt:

Just read the Slack convo from 3 weeks ago. So is the concensus to go ahead with an implementation like @helen's screenshot? http://cl.ly/3F1L0N3z1M0F0Z3t0X3W

I wouldn't mind moving to single column mobile layouts for all of our list table screens. My inclination is to run with Helen's screenshot and iterate from there.

#12 @DrewAPicture
5 years ago

  • Milestone changed from 4.2 to Future Release
  • Priority changed from high to normal

No patch activity in the last few weeks. Punting to future release.

#13 @helen
5 years ago

I missed this - this is one of the screens that I think needs more of a rethought to work on a narrow screen. Interim fixes are great, I'm just not convinced that comments really gets very much better with them. Happy to lay out what I think could be the path with my very old experiment going forward, if we think that's a route we want to pursue.

@ryan
4 years ago

Comment action links now have room

#14 @ryan
4 years ago

  • Milestone changed from Future Release to 4.3
  • Resolution set to fixed
  • Status changed from new to closed

Fixed by the work on #32395.

This ticket was mentioned in Slack in #core-flow by boren. View the logs.


4 years ago

Note: See TracTickets for help on using tickets.