WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#30014 closed defect (bug) (fixed)

Twenty Fifteen: Isolate :not selectors from CSS2 selectors

Reported by: peterwilsoncc Owned by: SergeyBiryukov
Milestone: 4.1 Priority: normal
Severity: normal Version: 4.1
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

Browsers that do not support CSS3 :not selectors will ignore entire selector/property groups if they are paired with CSS2 selectors. CSS3 selectors need to be isolated.

I.E., IE8 will ignore this entire block:

body,
.hentry:not(p) {
  foo: bar;
}

Attachments (2)

30014.diff (1.3 KB) - added by peterwilsoncc 7 years ago.
30014.1.diff (1.6 KB) - added by iamtakashi 7 years ago.
Isolate :not selectors from CSS2 selectors for IE8 and 7.

Download all attachments as: .zip

Change History (8)

@peterwilsoncc
7 years ago

#1 @peterwilsoncc
7 years ago

  • Type changed from enhancement to defect (bug)

#2 @peterwilsoncc
7 years ago

  • Summary changed from Isolate :not selectors from CSS2 selectors to Twenty Fifteen: Isolate :not selectors from CSS2 selectors

#3 @iamtakashi
7 years ago

  • Keywords has-patch added

A good catch. With this, we can remove some duplicated rules from IE specific stylesheet. Here is a updated patch.

@iamtakashi
7 years ago

Isolate :not selectors from CSS2 selectors for IE8 and 7.

#4 @SergeyBiryukov
7 years ago

  • Milestone changed from Awaiting Review to 4.1

#5 @SergeyBiryukov
7 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 29996:

Twenty Fifteen: Isolate :not selectors from CSS2 selectors.

props peterwilsoncc, iamtakashi.
fixes #30014.

#6 @nacin
7 years ago

In the future, I think [29996] would be an excellent situation for a code comment, both so someone later doesn't collapse these, and so someone reading the CSS can learn.

Note: See TracTickets for help on using tickets.