Opened 9 years ago
Closed 9 years ago
#30016 closed enhancement (wontfix)
Twenty Fifteen: Use inherit in color scheme where possible.
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | minor | Version: | 4.1 |
Component: | Bundled Theme | Keywords: | has-patch needs-refresh |
Focuses: | Cc: |
Description
A number of the color scheme styles defined in twentyfifteen's HTML header can be moved to style.css and use inherit.
Low hanging targets include table cell border colours, blockquote > cite, et al.
Patch to come.
Attachments (2)
Change History (16)
#1
@
9 years ago
- Summary changed from Use inherit in twentyfifteen color scheme where possible. to Twenty Fifteen: Use inherit in color scheme where possible.
- Version set to trunk
#4
@
9 years ago
- Keywords has-patch 2nd-opinion added; needs-patch removed
I dug into this and refactored out:
color
for children of.widget
border-color
forth
,td
of.widget table
Those were the low hanging fruits that peterwilsoncc mentioned, but I think we could probably do more — just figured I'd put something up.
#5
in reply to:
↑ 3
@
9 years ago
Patch catching a few more items.
I grouped all the items inheriting for the colour scheme at the bottom of the file to keep close the the header code. There are a few colours defined within the style sheet.
#7
@
9 years ago
I've tested inherit.30016.patch but the patch seems to need more work.
- Custom Header Text Color is not applied correctly to the site title and the site description if the current color scheme isn't default.
- Custom Sidebar Text Color is not applied correctly to
blockquote
if the current color scheme isn't default. - Custom Sidebar Text Color is not applied correctly to hover state of links in widgets if the current color scheme isn't the default. It should be 70% of the chosen color.
- Custom Sidebar Text Color is not applied correctly to captions in widgets if the current color scheme isn't the default. It should be 70% of the chosen color.
- Custom Sidebar Text Color is not applied correctly to
cite
andsmall
inblockquote
if the current color scheme isn't the default.
@peterwilsoncc is there a patch coming along?