Make WordPress Core

Opened 12 years ago

Closed 12 years ago

#30016 closed enhancement (wontfix)

Twenty Fifteen: Use inherit in color scheme where possible.

Reported by: peterwilsoncc Owned by:
Priority: normal Milestone:
Component: Bundled Theme Version: 4.1
Severity: minor Keywords: has-patch needs-refresh
Cc: Focuses:

Description

A number of the color scheme styles defined in twentyfifteen's HTML header can be moved to style.css and use inherit.

Low hanging targets include table cell border colours, blockquote > cite, et al.

Patch to come.

Attachments (2)

30016.patch (1.6 KB ) - added by jessepollak 12 years ago.
inherit.30016.patch (3.8 KB ) - added by peterwilsoncc 12 years ago.
Twenty Fifteen: Inherit colors where possible in color scheme.

Download all attachments as: .zip

Change History (16)

#1 @DrewAPicture
12 years ago

  • Summary Use inherit in twentyfifteen color scheme where possible.Twenty Fifteen: Use inherit in color scheme where possible.
  • Versiontrunk

#2 @iandstewart
12 years ago

  • Keywords needs-patch added
  • Milestone Awaiting Review4.1

#3 follow-up: @iandstewart
12 years ago

@peterwilsoncc is there a patch coming along?

#4 @jessepollak
12 years ago

  • Keywords has-patch 2nd-opinion added; needs-patch removed

I dug into this and refactored out:

  • color for children of .widget
  • border-color for th, td of .widget table

Those were the low hanging fruits that peterwilsoncc mentioned, but I think we could probably do more — just figured I'd put something up.

@jessepollak
12 years ago

#5 in reply to: ↑ 3 @peterwilsoncc
12 years ago

Patch catching a few more items.

I grouped all the items inheriting for the colour scheme at the bottom of the file to keep close the the header code. There are a few colours defined within the style sheet.

@peterwilsoncc
12 years ago

Twenty Fifteen: Inherit colors where possible in color scheme.

#6 @jessepollak
12 years ago

Much better :)

#7 @iamtakashi
12 years ago

I've tested inherit.30016.patch but the patch seems to need more work.

  1. Custom Header Text Color is not applied correctly to the site title and the site description if the current color scheme isn't default.
  2. Custom Sidebar Text Color is not applied correctly to blockquote if the current color scheme isn't default.
  3. Custom Sidebar Text Color is not applied correctly to hover state of links in widgets if the current color scheme isn't the default. It should be 70% of the chosen color.
  4. Custom Sidebar Text Color is not applied correctly to captions in widgets if the current color scheme isn't the default. It should be 70% of the chosen color.
  5. Custom Sidebar Text Color is not applied correctly to cite and small in blockquote if the current color scheme isn't the default.

This ticket was mentioned in Slack in #core-themes by iandstewart. View the logs.


12 years ago

#9 @iandstewart
12 years ago

  • Keywords needs-refresh added; 2nd-opinion removed

#10 @iandstewart
12 years ago

  • Severity normalminor

This ticket was mentioned in Slack in #core-themes by iamtakashi. View the logs.


12 years ago

#12 @iandstewart
12 years ago

  • Milestone 4.1Awaiting Review

This ticket was mentioned in Slack in #core-themes by peterwilsoncc. View the logs.


12 years ago

#14 @iandstewart
12 years ago

  • Milestone Awaiting Review
  • Resolutionwontfix
  • Status newclosed

With beta on the way, we're marking this one as won't fix.

Note: See TracTickets for help on using tickets.