Can't put buttons in the Publish meta box

[ericlewis]

<?php
add_action( 'post_submitbox_misc_actions', function() { ?><button type='button'>hi</button><?php } );

Clicking that button and then preview will break your stuffs.

This is because this selector is too greedy. We should remove the :button selector here.

[SergeyBiryukov]

Introduced in [7103], refactored in [11874] and [26995].

[helen]

What does "break your stuffs" entail, and is there any possibility people are relying on this currently for whatever reason? Not against removing it, just like to know the details first.

[ericlewis]

attachment:30035.mov​ shows what putting a button in the Publish meta box does.

Clicking our button adds the callback that's only intended for the submit button, so when Preview button is clicked, this callback runs unintentionally, and disables the submit buttons.

[adamsilverstein]

Replying to ericlewis:

attachment:30035.mov​ shows what putting a button in the Publish meta box does.

Clicking our button adds the callback that's only intended only to be added when the submit button is clicked, so when Preview button is clicked, this callback runs unintentionally, and disables the submit buttons.

Makes sense; wondering why :button was used in the first place, agree seems overly aggressive!

[helen]

Still curious if anybody is weirdly relying on this, or if this was done this way for a specific reason - paging azaozz.

[ericlewis]

azaozz and I spoke about it in IRC a while ago, ​he agreed it was too generous of a selector and we should remove it.

[helen]

In 30698:

Don't over-target buttons in the publish meta box.

This selector caused breakage for any custom buttons added.

props ericlewis.
fixes #30035.