Make WordPress Core

Opened 10 years ago

Closed 9 years ago

#30040 closed defect (bug) (wontfix)

Spelling of Password should be Passwords instead of Password on installation page

Reported by: ankit-k-gupta's profile Ankit K Gupta Owned by: drewapicture's profile DrewAPicture
Milestone: Priority: normal
Severity: normal Version: 2.7
Component: Text Changes Keywords: has-patch
Focuses: ui Cc:

Description

Password as the descriptive text is talking about Passwords in the abstract, rather that this specific one.
It should be "Passwords" instead of 'Password'. It is being used in multiple files.

Usernames and Passwords should be displayed in the same manner on a single page.

Attachments (7)

password.png (26.4 KB) - added by Ankit K Gupta 10 years ago.
Screenshot of Installation page
30040.patch (729 bytes) - added by Ankit K Gupta 10 years ago.
patch file
30040-1.patch (719 bytes) - added by Ankit K Gupta 10 years ago.
Updated patch file as per helen suggestion.
WillLookLikeThisAfterPatch.png (21.7 KB) - added by Ankit K Gupta 10 years ago.
Will Look LikeThis After Patch
30040.2.patch (728 bytes) - added by Ankit K Gupta 9 years ago.
Updated patch file with "Hint:" text
password_install_4.3.png (54.4 KB) - added by DrewAPicture 9 years ago.
password_reset_4.3.png (57.9 KB) - added by DrewAPicture 9 years ago.

Download all attachments as: .zip

Change History (18)

@Ankit K Gupta
10 years ago

Screenshot of Installation page

@Ankit K Gupta
10 years ago

patch file

#1 @Ankit K Gupta
10 years ago

  • Keywords has-patch added

#2 @ocean90
10 years ago

  • Focuses ui added

Related: #30034, [29962]

#3 follow-up: @MikeHansenMe
10 years ago

I think Password is correct because it is referring to a single password that you have to enter multiple times.

#4 in reply to: ↑ 3 @Ankit K Gupta
10 years ago

Replying to MikeHansenMe:

I think Password is correct because it is referring to a single password that you have to enter multiple times.

I agree with you but the same password rules applies to all passwords not to specific one like usernames refer #30034 .

Last edited 10 years ago by Ankit K Gupta (previous) (diff)

#5 follow-up: @helen
10 years ago

I think it might be okay to be "Passwords" (would like opinion of docs and text folks), but definitely not "The passwords".

#6 in reply to: ↑ 5 @Ankit K Gupta
10 years ago

Replying to helen:

I think it might be okay to be "Passwords" (would like opinion of docs and text folks), but definitely not "The passwords".

@helen
Thanks for your nice suggestion, I've updated the patch file. Removed 'The' word before of Passwords hint text.
Also removed 'Hint' text, for maintaining consistency on same page. We are not using the 'Hint' before of Username although giving hint, like passwords.

Please let me know if you have any other suggestion.

Thanks

@Ankit K Gupta
10 years ago

Updated patch file as per helen suggestion.

@Ankit K Gupta
10 years ago

Will Look LikeThis After Patch

#7 @jeremyfelt
9 years ago

  • Component changed from Upgrade/Install to Text Changes
  • Milestone changed from Awaiting Review to Future Release
  • Version changed from trunk to 2.7

Going from "Passwords should be" to "make it stronger" seems off a bit. I'm not sure that them would work either. I do like the idea of matching "Usernames" without "the".

The current text for passwords appears to come from [8722].

@Ankit K Gupta
9 years ago

Updated patch file with "Hint:" text

#8 @Ankit K Gupta
9 years ago

As this ticket has 'Future Release' milestone. Can we consider it for 4.3 ?

#9 @wonderboymusic
9 years ago

  • Milestone changed from Future Release to 4.4
  • Owner set to DrewAPicture
  • Status changed from new to assigned

#10 @DrewAPicture
9 years ago

  • Status changed from assigned to accepted

#11 @DrewAPicture
9 years ago

  • Milestone 4.4 deleted
  • Resolution set to wontfix
  • Status changed from accepted to closed

Following the recent changes to password-setting flows, the only place where this string is currently in use is on the password reset form.

  • See password_install_4.3.png for the new password flow on the install screen (generator + strength meter + single input, no hint).
  • See password_reset_4.3.png for the reset password flow that comes along with the strength meter + a generated password + the hint.

In light of the above changes:

  1. The password entry field is now only a single input on reset pass, thus fitting with the singular nature of "the password"
  2. The password hint no longer accompanies the username hint

Closing as wontfix. Thanks for the work everybody.

Note: See TracTickets for help on using tickets.