Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#30043 closed defect (bug) (fixed)

Twenty Fifteen: Skip to content font and styling

Reported by: afercia's profile afercia Owned by: iandstewart's profile iandstewart
Milestone: 4.1 Priority: normal
Severity: normal Version: 4.1
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

Very subtle thing:

  • "Open Sans" is not available when not logged-in, unless it's installed in your system fonts, so it fallbacks to sans-serif which depends on platforms and devices, should use "Noto Sans"
  • when logged in, should use "Open Sans" and have the same style as "Skip to toolbar" and "Log out" for consistency
  • should use a selector to target just the skip-link

"Noto Sans" bold is "bolder" than "Open Sans" bold but I guess we can live with that.
For testing, be sure "Open Sans" is *not* installed on your system.

See screenshots, where I've moved and made the 3 links temporary visible to better compare them.

logged in and logged out "before" on Windows, fallbacks to Arial:

https://cldup.com/1-G8WopKGT.png

logged in and logged out "after":

https://cldup.com/ilkRVwCHHD.png

Attachments (2)

30043.patch (1.2 KB) - added by afercia 10 years ago.
30043.1.diff (1.1 KB) - added by iamtakashi 10 years ago.
Cleaned-up patch.

Download all attachments as: .zip

Change History (6)

@afercia
10 years ago

#1 @afercia
10 years ago

  • Keywords has-patch added

@iamtakashi
10 years ago

Cleaned-up patch.

#2 @iandstewart
10 years ago

@iamtakashi can you add a visual record? Screenshots! :)

#3 @iandstewart
10 years ago

  • Milestone changed from Awaiting Review to 4.1

#4 @iandstewart
10 years ago

  • Owner set to iandstewart
  • Resolution set to fixed
  • Status changed from new to closed

In 29976:

Twenty Fifteen: updated styles for skip link.

Props afercia and iamtakashi, fixes #30043.

Note: See TracTickets for help on using tickets.