Make WordPress Core

Opened 9 years ago

Closed 9 years ago

#30059 closed defect (bug) (fixed)

Twenty Fifteen: Social Links Menu and Skype URIs

Reported by: afercia's profile afercia Owned by: iandstewart's profile iandstewart
Milestone: 4.1 Priority: normal
Severity: normal Version: 4.1
Component: Bundled Theme Keywords: has-patch commit
Focuses: Cc:

Description

In the main stylesheet there's one rule to support Skype links in the Social Menu, btw they won't work unless you add a "skype" protocol in the kses allowed protocols. Without that, you can't save a link with a "URL" value like, for example, "skype:echo123?call".

Proposed patch uses the "kses_allowed_protocols" filter and also fixes the doubled ":before:before" in the stylesheet.

Attachments (2)

30059.patch (1.1 KB) - added by afercia 9 years ago.
30059.1.diff (494 bytes) - added by iamtakashi 9 years ago.
Remove Skype from supported social links since we need to add their protocol.

Download all attachments as: .zip

Change History (10)

@afercia
9 years ago

#1 @afercia
9 years ago

  • Keywords has-patch added

#2 @iamtakashi
9 years ago

I'm kind of ok to remove Skype support rather than adding a Skype protocol.

#3 follow-up: @afercia
9 years ago

no objections to remove it, if there are security concerns, otherwise I don't see so much difference between "skype:" and "mailto:" links (which are supported)

#4 in reply to: ↑ 3 @iamtakashi
9 years ago

Replying to afercia:

no objections to remove it, if there are security concerns, otherwise I don't see so much difference between "skype:" and "mailto:" links (which are supported)

OK, let's remove Skype. Do you want to cook a quick patch?

#5 @afercia
9 years ago

Oh I guess there's no need, it's faster and simpler if you remove the rule from style.css I can live without a prop :)

@iamtakashi
9 years ago

Remove Skype from supported social links since we need to add their protocol.

#6 @iandstewart
9 years ago

  • Keywords commit added

#7 @iandstewart
9 years ago

  • Milestone changed from Awaiting Review to 4.1

#8 @iandstewart
9 years ago

  • Owner set to iandstewart
  • Resolution set to fixed
  • Status changed from new to closed

In 30010:

Twenty Fifteen: removing Skype from the list of social links is easier than adding skype to $allowed_protocols.

Props iamtakashi, fixes #30059.

Note: See TracTickets for help on using tickets.