WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #30062, comment 7


Ignore:
Timestamp:
10/22/2014 07:28:30 PM (5 years ago)
Author:
ericmann
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #30062, comment 7

    initial v1  
    55
    66We looked through Trac and saw no open tickets referencing or discussing the issue, so I opened this one to a) create a discussion and b) give us a ticket number we could reference in unit tests (you can run the tests for ''just'' our patch with a `--group 30062` filter).
     7
     8Your first reference to your patch pointed to an old (already "completed") ticket and also stated it was out of date. We had already started coding at that point, so we kept moving forward. I also haven't had time to review your patch until today in the first place - it's a great effort and, while different than our approach, definitely makes good headway on the same issue.
    79
    810> I think the loaded/registered idea is very interesting. It doesn't map 1:1 to the way we handle meta boxes, which may prompt some to consider it a bit confusing. But it's a cool approach.