WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#30066 closed defect (bug) (fixed)

Validator list is not floating correctly

Reported by: SergeyBiryukov Owned by: SergeyBiryukov
Milestone: 4.1 Priority: normal
Severity: minor Version: 3.3
Component: Help/About Keywords: good-first-bug has-patch needs-testing
Focuses: Cc:

Description

Sometimes a longer name in the list of validators prevents the next list items from floating correctly. See the screenshot.

Replacing float: left with display: inline-block; vertical-align: top; should fix this.

Attachments (3)

30066.png (26.0 KB) - added by SergeyBiryukov 3 years ago.
30066.patch (373 bytes) - added by kosvrouvas 3 years ago.
Patch for validators list not floating correctly
30066.2.patch (430.5 KB) - added by kosvrouvas 3 years ago.
Update! Also changed wp-admin.min.css that blocked about.css. The current file contains both fixes!

Download all attachments as: .zip

Change History (7)

@SergeyBiryukov
3 years ago

@kosvrouvas
3 years ago

Patch for validators list not floating correctly

#1 @kosvrouvas
3 years ago

  • Keywords has-patch added; needs-patch removed

@kosvrouvas
3 years ago

Update! Also changed wp-admin.min.css that blocked about.css. The current file contains both fixes!

#2 @kosvrouvas
3 years ago

  • Keywords needs-testing added

#3 @SergeyBiryukov
3 years ago

Thanks for the patch, kosvrouvas.

No need to patch minified files, a post-commit task takes care of that.

There's a SCRIPT_DEBUG constant you can add to your wp-config.php file to use unminified files.

#4 @SergeyBiryukov
3 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 30037:

Make sure the validator list on Credits screen floats correctly with longer names.

props kosvrouvas.
fixes #30066.

Note: See TracTickets for help on using tickets.