WordPress.org

Make WordPress Core

Opened 13 years ago

Closed 7 years ago

Last modified 7 years ago

#3007 closed defect (bug) (worksforme)

wpautop error when div tags lack space before or after other text

Reported by: erik Owned by:
Milestone: Priority: normal
Severity: normal Version: 2.0.4
Component: Formatting Keywords:
Focuses: Cc:

Description

Texturize appears to have an issue figuring out where to put the paragraph tags if there are no lines between a div tag and the previous or next piece of text.

(Note: This is all with the visual rich editor turned off.)

I type this as the post content:

<div>
<a href="http://example.com">example.com</a>

Some pretty words here.
<div>

The source of the post when it is viewed is this:

					<div>
<a href="http://example.com">example.com</a></p>

<p>Test
</div>

The paragraph tags don't come out quite right.


This text, with a line between opening the div and the link:

<div>

<a href="http://example.com">example.com</a>

Some pretty words here.
</div>

Gets this source:

					<div>
<p><a href="http://example.com">example.com</a></p>
<p>Some text here.
</div>

Now the first paragraph tags open and close as expected.


Finally, if I put lines between both the open and close div tags and the nearest text:

<div>

<a href="http://example.com">example.com</a>

Some pretty words here.

</div>

I get this source:

					<div>
<p><a href="http://example.com">example.com</a></p>
<p>Some text here.</p>
</div>

Now both come out as expected.

Change History (13)

#1 @erik
13 years ago

  • Milestone set to 2.1
  • Summary changed from Texturize error with div-link-paragraph combination to Texturize error when div tags lack space before or after other text

Further examples, with only one thing between the divs. These:

<div>
<a href="http://example.com">example.com</a>

</div>

<div>

<a href="http://example.com">example.com</a>
</div>

<div>
Sample text.

</div>

<div>

Sample text.
</div>

Create these:


<div>
<a href="http://example.com">example.com</a></p>
</div>

<div>
<p><a href="http://example.com">example.com</a>
</div>

<div>
Sample text.</p>
</div>

<div>
<p>Sample text.
</div>

#2 @erik
13 years ago

  • Keywords wpautop added; texturize removed
  • Summary changed from Texturize error when div tags lack space before or after other text to wpautop error when div tags lack space before or after other text

Oops. Not texturize, but wpautop, I think.

#3 @matt
12 years ago

  • Milestone changed from 2.1 to 2.2

#4 @foolswisdom
12 years ago

  • Milestone changed from 2.2 to 2.4

#5 @santosj
11 years ago

  • Component changed from General to Template

#6 @thee17
11 years ago

  • Milestone changed from 2.5 to 2.6

#7 @Denis-de-Bernardy
10 years ago

  • Keywords needs-patch added; wpautop removed

the output changed somewhat, but the bug is still current

#8 @Denis-de-Bernardy
10 years ago

See also: #3362 (same bug with blockquotes)

#9 @Denis-de-Bernardy
10 years ago

  • Component changed from Template to Formatting

#10 @hakre
10 years ago

Please close as wontfix. Fixing things will break other things and vice-versa. I do not know a single serious developer that wants to touch this.

Best would be to get a binding description first what must (not)/should (not)/can (not) be done by wpautop. Then testcases must be written (executeable ones) and then the function can be developed accordingly.

related: #2833, #1706

#11 @azaozz
9 years ago

  • Milestone changed from 2.9 to Future Release

#12 @wonderboymusic
7 years ago

  • Keywords needs-patch removed
  • Resolution set to worksforme
  • Status changed from new to closed

Currently, trunk (using the original examples) produces:

<div>
<p><a href="http://example.com">example.com</a>Some pretty words here.</p>
</div>
<div>
<p><a href="http://example.com">example.com</a></p>
<p>Some pretty words here.</p>
</div>
<div>
<p><a href="http://example.com">example.com</a></p>
<p>Some pretty words here.</p>
</div>

I'm inclined to think this is working as expected. If you are using newlines in the editor to produce line-breaks that result in <p>s, you can preview til your heart's content.

#13 @helenyhou
7 years ago

  • Milestone Future Release deleted
Note: See TracTickets for help on using tickets.