WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#30101 closed defect (bug) (wontfix)

Check box label should be clickable, same as other check box label of other pages

Reported by: Ankit K Gupta Owned by: johnbillion
Milestone: Priority: normal
Severity: normal Version: 4.0
Component: Administration Keywords: 2nd-opinion close
Focuses: accessibility Cc:

Description

Check box label should have similar behavior on all page.
Label of new user page are clickable and having cursor pointer but label of profile page are not clickable.

Attachments (4)

mix.jpg (73.7 KB) - added by Ankit K Gupta 6 years ago.
Screenshot of new user and profile page
30101.patch (1.9 KB) - added by Ankit K Gupta 6 years ago.
Patch file
30101.2.patch (1.9 KB) - added by Ankit K Gupta 6 years ago.
Patch file
30101.3.patch (2.0 KB) - added by DrewAPicture 6 years ago.

Download all attachments as: .zip

Change History (13)

@Ankit K Gupta
6 years ago

Screenshot of new user and profile page

@Ankit K Gupta
6 years ago

Patch file

@Ankit K Gupta
6 years ago

Patch file

#1 @Ankit K Gupta
6 years ago

  • Keywords has-patch added

#2 @DrewAPicture
6 years ago

  • Focuses accessibility added
  • Keywords commit added
  • Milestone changed from Awaiting Review to 4.1

#3 @johnbillion
6 years ago

  • Owner set to johnbillion
  • Resolution set to fixed
  • Status changed from new to closed

In 30027:

Add labels to the Personal Options input fields on the user profile editing screen. Fixes #30101. Props Ankit K Gupta

This ticket was mentioned in Slack in #accessibility by toscho. View the logs.


6 years ago

#5 @joedolson
6 years ago

This changed should be reverted; this patch adds a second label to fields that already have a label, which could lead to some very confused behavior for screen readers. The fields are sufficiently labeled already.

There's a possibility for using aria-describedby or aria-labelledby in these contexts, but adding a second label is definitely *not* an option.

#6 @SergeyBiryukov
6 years ago

In 31281:

Revert [30027]. These fields are already sufficiently labeled; duplicate labels can lead to confused behavior for screen readers.

see #31117, #30101.

#7 @johnbillion
6 years ago

  • Keywords 2nd-opinion added; has-patch commit removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

#8 @SergeyBiryukov
6 years ago

  • Keywords close added
  • Milestone changed from 4.1 to Awaiting Review

Seems to be a wontfix, per comment:6. See also the discussion in #31117.

Version 0, edited 6 years ago by SergeyBiryukov (next)

#9 @joedolson
6 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.