Twenty Fifteen: Translation-ready search form

[sdavis2702]

Twenty Fifteen is translation-ready, of course. But no default theme has included a searchform.php template file since Twenty Eleven. I don't understand why.

With search form markup being part of core and going so far as to intentionally use the HTML5 form in Twenty Fifteen, which puts the search input field placeholder text right on the screen, I think the search form should be translation-ready using the theme's text domain.

[sdavis2702]

search form template file

[SergeyBiryukov]

I think the goal is for bundled themes to use the core functionality where possible instead of overriding it with custom templates.

We could probably add a new argument for get_search_form() to provide a custom placeholder string, but what's wrong with using the core string?

[sdavis2702]

I thought about that not too long after opening this ticket. I think I associate get_search_form() with the theme so much because of how often it's used in themes and the fact that it's almost always front-facing on every site.

But if get_search_form() needed to be overwritten in a theme for the translation purposes, so would comment_form(), the protected post password form, etc. So no... after more thought, I actually disagree with my own ticket now.

Feel free to close!