WordPress.org
Get WordPress

Make WordPress Core

Opened 12 years ago

Closed 9 years ago

Last modified 8 years ago

#30120 closed enhancement (wontfix)

Internationalize Hello Dolly

Reported by: Otto42 Owned by:
Priority: normal Milestone:
Component: I18N Version:
Severity: normal Keywords: has-patch
Cc: Focuses:

Description

All plugins should support the i18n functions. No exceptions.

Attachments (1)

30120.patch​ (930 bytes ) - added by Otto42 12 years ago.
Add text-domain header, bump version, eliminate ending closing php tags

Download all attachments as: .zip

Change History (14)

#1 @Otto42
12 years ago

  • Keywords has-patch added

@Otto42
12 years ago

Add text-domain header, bump version, eliminate ending closing php tags

#3 @DrewAPicture
12 years ago

  • Component General → I18N
  • Milestone Awaiting Review
  • Resolution → duplicate
  • Status new → closed

Let's consolidate over to #30353.

This ticket was mentioned in ​Slack in #polyglots by sergey. ​View the logs.
9 years ago

#5 @SergeyBiryukov
9 years ago

  • Milestone → Awaiting Review
  • Resolution duplicate
  • Status closed → reopened

This was brought up a couple months ago in several discussions on #polyglots channel:
​https://wordpress.slack.com/archives/C02RP50LK/p1493188906077157
​https://wordpress.slack.com/archives/C02RP50LK/p1493806620691694
​https://wordpress.slack.com/archives/C02RP50LK/p1495608311387916
​https://wordpress.slack.com/archives/C02RP50LK/p1496213094682103

To summarize, Hello Dolly is a sample plugin that is supposed to follow all the best practices. I18N is one of those, but the plugin currently ​displays a warning on the translation page due to a missing text domain:

This plugin is not properly prepared for localization (View detailed logs on Slack). If you would like to translate this plugin, please contact the author.

This is less than ideal, a sample plugin shouldn't display any warnings. The lyrics may not need translation, but the description does. Each plugin should have a Text Domain: header, and that's exactly what the patch does.

#30353 was derailed into "remove Hello Dolly from core" and got closed as wontfix, so let's reopen this one.

Last edited 9 years ago by SergeyBiryukov (previous) (diff)

This ticket was mentioned in ​Slack in #polyglots by sergey. ​View the logs.
9 years ago

#7 @netweb
9 years ago

On a related note: Hello Dolly is currently included in PHP coding standards update in #41057

#8 @SergeyBiryukov
9 years ago

  • Milestone Awaiting Review → 4.9

This ticket was mentioned in ​Slack in #polyglots by casiepa. ​View the logs.
9 years ago

This ticket was mentioned in ​Slack in #polyglots by coachbirgit. ​View the logs.
9 years ago

#11 @netweb
9 years ago

  • Keywords commit added

Let's get this in...

#12 @ocean90
9 years ago

  • Keywords commit removed
  • Milestone 4.9
  • Resolution → wontfix
  • Status reopened → closed

Since [37562] the text domain is no longer required. The warning on translate.w.org is also gone.

This ticket was mentioned in ​Slack in #core by audrasjb. ​View the logs.
8 years ago

Note: See TracTickets for help on using tickets.