#30120 closed enhancement (wontfix)
Internationalize Hello Dolly
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Milestone: | Priority: | normal | |
| Severity: | normal | Version: | |
| Component: | I18N | Keywords: | has-patch |
| Focuses: | Cc: |
Description
All plugins should support the i18n functions. No exceptions.
Attachments (1)
Change History (14)
#3
@
10 years ago
- Component changed from General to I18N
- Milestone Awaiting Review deleted
- Resolution set to duplicate
- Status changed from new to closed
Let's consolidate over to #30353.
This ticket was mentioned in Slack in #polyglots by sergey. View the logs.
8 years ago
#5
@
7 years ago
- Milestone set to Awaiting Review
- Resolution duplicate deleted
- Status changed from closed to reopened
This was brought up a couple months ago in several discussions on #polyglots channel:
https://wordpress.slack.com/archives/C02RP50LK/p1493188906077157
https://wordpress.slack.com/archives/C02RP50LK/p1493806620691694
https://wordpress.slack.com/archives/C02RP50LK/p1495608311387916
https://wordpress.slack.com/archives/C02RP50LK/p1496213094682103
To summarize, Hello Dolly is a sample plugin that is supposed to follow all the best practices. I18N is one of those, but the plugin currently displays a warning on the translation page due to a missing text domain:
This plugin is not properly prepared for localization (View detailed logs on Slack). If you would like to translate this plugin, please contact the author.
This is less than ideal, a sample plugin shouldn't display any warnings. The lyrics may not need translation, but the description does. Each plugin should have a Text Domain: header, and that's exactly what the patch does.
#30353 was derailed into "remove Hello Dolly from core" and got closed as wontfix, so let's reopen this one.
This ticket was mentioned in Slack in #polyglots by sergey. View the logs.
7 years ago
#7
@
7 years ago
On a related note: Hello Dolly is currently included in PHP coding standards update in #41057
This ticket was mentioned in Slack in #polyglots by casiepa. View the logs.
7 years ago
This ticket was mentioned in Slack in #polyglots by coachbirgit. View the logs.
7 years ago
#12
@
7 years ago
- Keywords commit removed
- Milestone 4.9 deleted
- Resolution set to wontfix
- Status changed from reopened to closed
Since [37562] the text domain is no longer required. The warning on translate.w.org is also gone.
Add text-domain header, bump version, eliminate ending closing php tags