WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 19 months ago

Last modified 9 months ago

#30120 closed enhancement (wontfix)

Internationalize Hello Dolly

Reported by: Otto42 Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-patch
Focuses: Cc:

Description

All plugins should support the i18n functions. No exceptions.

Attachments (1)

30120.patch (930 bytes) - added by Otto42 4 years ago.
Add text-domain header, bump version, eliminate ending closing php tags

Download all attachments as: .zip

Change History (14)

#1 @Otto42
4 years ago

  • Keywords has-patch added

@Otto42
4 years ago

Add text-domain header, bump version, eliminate ending closing php tags

#3 @DrewAPicture
4 years ago

  • Component changed from General to I18N
  • Milestone Awaiting Review deleted
  • Resolution set to duplicate
  • Status changed from new to closed

Let's consolidate over to #30353.

This ticket was mentioned in Slack in #polyglots by sergey. View the logs.


2 years ago

#5 @SergeyBiryukov
22 months ago

  • Milestone set to Awaiting Review
  • Resolution duplicate deleted
  • Status changed from closed to reopened

This was brought up a couple months ago in several discussions on #polyglots channel:
https://wordpress.slack.com/archives/C02RP50LK/p1493188906077157
https://wordpress.slack.com/archives/C02RP50LK/p1493806620691694
https://wordpress.slack.com/archives/C02RP50LK/p1495608311387916
https://wordpress.slack.com/archives/C02RP50LK/p1496213094682103

To summarize, Hello Dolly is a sample plugin that is supposed to follow all the best practices. I18N is one of those, but the plugin currently displays a warning on the translation page due to a missing text domain:

This plugin is not properly prepared for localization (View detailed logs on Slack). If you would like to translate this plugin, please contact the author.

This is less than ideal, a sample plugin shouldn't display any warnings. The lyrics may not need translation, but the description does. Each plugin should have a Text Domain: header, and that's exactly what the patch does.

#30353 was derailed into "remove Hello Dolly from core" and got closed as wontfix, so let's reopen this one.

Last edited 22 months ago by SergeyBiryukov (previous) (diff)

This ticket was mentioned in Slack in #polyglots by sergey. View the logs.


22 months ago

#7 @netweb
22 months ago

On a related note: Hello Dolly is currently included in PHP coding standards update in #41057

#8 @SergeyBiryukov
22 months ago

  • Milestone changed from Awaiting Review to 4.9

This ticket was mentioned in Slack in #polyglots by casiepa. View the logs.


22 months ago

This ticket was mentioned in Slack in #polyglots by coachbirgit. View the logs.


22 months ago

#11 @netweb
19 months ago

  • Keywords commit added

Let's get this in...

#12 @ocean90
19 months ago

  • Keywords commit removed
  • Milestone 4.9 deleted
  • Resolution set to wontfix
  • Status changed from reopened to closed

Since [37562] the text domain is no longer required. The warning on translate.w.org is also gone.

This ticket was mentioned in Slack in #core by audrasjb. View the logs.


9 months ago

Note: See TracTickets for help on using tickets.