WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#30132 closed defect (bug) (fixed)

Remove <address> option in formatselect TinyMCE dropdown

Reported by: mor10 Owned by: azaozz
Milestone: 4.1 Priority: normal
Severity: normal Version:
Component: TinyMCE Keywords: has-patch
Focuses: Cc:

Description

While paragraph, div, and the stack of H levels make sense in the context of the formatselect in TinyMCE, <address> does not. It's inclusion seems arbitrary though I've been told it is a default from the application. The concern is that due to the poorly understood nature of the tag it is likely to be used erroneously if at all.

I propose removing it permanently to avoid user error.

For reference, this is the description of the <address> tag as per MDN:

"The HTML <address> Element may be used by authors to supply contact information for its nearest <article> or <body> ancestor; in the latter case, it applies to the whole document."

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/address

Attachments (1)

30132.patch (629 bytes) - added by iseulde 6 years ago.

Download all attachments as: .zip

Change History (10)

This ticket was mentioned in Slack in #core by mor10. View the logs.


6 years ago

#2 @azaozz
6 years ago

IMHO we should remove it. Seems <address> is very rarely used and is out of context inside the post_content unless the theme uses <article> tags.

@iseulde
6 years ago

#3 @iseulde
6 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 4.1

#4 @iseulde
6 years ago

Alternatively we can ask spocke to remove it.

#5 @helen
6 years ago

avryl - did you ask spocke, or should we go with the patch?

#6 @iseulde
6 years ago

I just asked, but if we want to remove it for 4.1, we should probably use the patch until it's changed in TinyMCE.

#7 @azaozz
6 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In 30733:

TinyMCE: remove <address> from the block formats drop-down. Props avryl, mor10. Fixes #30132.

This ticket was mentioned in Slack in #core-editor by afercia. View the logs.


6 years ago

This ticket was mentioned in Slack in #core-editor by iseulde. View the logs.


6 years ago

Note: See TracTickets for help on using tickets.