Twenty Fifteen: Replaces ellipses with a Continue reading link.

[davidakennedy]

To help meet accessibility-ready requirements, we need to make clean automatically-generated excepts. We should replace the ellipses (appended to automatically generated excerpts) with a Continue reading link.

This would mirror what we already do in the content.php and other content areas, and is catching another use-case:

<?php
    /* translators: %s: Name of current post */
    the_content( sprintf(
        esc_html__( 'Continue reading %s', 'twentyfifteen' ),
            the_title( '<span class="screen-reader-text">', '</span>', false )
        ) );
?>

We could add it in the template-tags.php file and follow this example: ​http://www.fklein.info/read-more-link-excerpts/

[sharonaustin]

Tested the patch, and works as intended. Thank you, David! ​http://red-hound.com/trunk29747/trunk/src/?s=replaces+ellipses

[rianrietveld]

Hi David, tested the patch and it works, nice job!

[michaelbeil]

Hey David, the patch works well.

[iamtakashi]

Don't we want ellipses before the "Continue reading" link? In some cases, it reads weird :)

[kraftbj]

On wp-admin/edit.php, when using the "excerpt" display mode, this filter is adding "Continue Reading" links to the admin. I suggest an ! is_admin() or similar check to keep the admin interface clean.

Patch forthcoming (without yet an ellipses as suggested by iamtakashi)

Related: #30026 (same thing in Twenty Ten/Eleven)
Related: #30024 (add Continued Reading links to manual excerpts, closed as wontfix currently)

[kraftbj]

Disables the filter when is_admin

[iamtakashi]

Also, we don't want the arrow. Having more-link class should match with other continue reading links.

[davidakennedy]

Replying to iamtakashi:

Also, we don't want the arrow. Having more-link class should match with other continue reading links.

Great catches, @iamtakashi and @kraftbj!

I've updated the patch to include @kraftbj's changes and to remove the right arrow in favor of Genericon approach.

[davidakennedy]

This time, a patch without the press-this.php stuff. Sorry about that.

[iamtakashi]

Replying to davidakennedy:

This time, a patch without the press-this.php stuff. Sorry about that.

What about having ellipsis before the link?

[davidakennedy]

Replying to iamtakashi:

Replying to davidakennedy:

This time, a patch without the press-this.php stuff. Sorry about that.

What about having ellipsis before the link?

Sorry @iamtakashi! Working on too many similar patches. I will get this right eventually. :)

[iamtakashi]

Someone can know more about it but, would the leading space before the ellipsis be concerned? That string is not for translation so it might be ok but it weirds me out a bit.

Maybe, we should wrap the ellipsis with a span and give it space with css?

[davidakennedy]

Replying to iamtakashi:

Someone can know more about it but, would the leading space before the ellipsis be concerned? That string is not for translation so it might be ok but it weirds me out a bit.

Maybe, we should wrap the ellipsis with a span and give it space with css?

Looks like we shouldn't do that. See: ​http://codex.wordpress.org/I18n_for_WordPress_Developers#Best_Practices

I'll do some research and adjust the patch.

[SergeyBiryukov]

Replying to davidakennedy:

Looks like we shouldn't do that. See: ​http://codex.wordpress.org/I18n_for_WordPress_Developers#Best_Practices

That only applies to translatable strings.

The leading space before the ellipsis looks weird to me too. Could we append the "Continue reading" link to the passed $more argument? Or just remove the space?

[davidakennedy]

Removes leading space; concatenates ellipses with spaces and link.

[iandstewart]

In 30237:

Twenty Fifteen: use continue reading links for auto-generated excerpts to provide a readable link for screenreaders.

Props davidakennedy, kraftbj, fixes #30135.

[grapplerulrich]

@davidakennedy - Why did you wrap add_filter( 'excerpt_more', 'twentyfifteen_excerpt_more' ); within the if ( ! function_exists( 'twentyfifteen_excerpt_more' )?

The reason I ask is that is that add_action( 'after_setup_theme', 'twentyfifteen_setup' ); is kept outside the check. ​https://github.com/WordPress/WordPress/blob/master/wp-content/themes/twentyfifteen/functions.php#L122