Make WordPress Core

Opened 12 years ago

Closed 12 years ago

#30137 closed defect (bug) (fixed)

Twenty Fifteen: Stop before 4.1 to activate the theme

Reported by: iamtakashi Owned by: iandstewart
Priority: normal Milestone: 4.1
Component: Bundled Theme Version: 4.1
Severity: blocker Keywords: has-patch needs-refresh
Cc: Focuses:

Description

As a part of effort to make people update their install to the latest version, let's not allow before 4.1 to activate the theme.

Attachments (1)

30137.diff​ (3.3 KB ) - added by iamtakashi 12 years ago.
Limit back compat to 4.1 and later versions.

Download all attachments as: .zip

Change History (13)

#1 @iandstewart
12 years ago

  • Milestone Awaiting Review → 4.1
  • Severity normal → blocker

#2 @iandstewart
12 years ago

  • Keywords needs-patch added

@iamtakashi
12 years ago

Limit back compat to 4.1 and later versions.

#3 @voldemortensen
12 years ago

  • Keywords has-patch added; needs-patch removed

#4 @iandstewart
12 years ago

  • Keywords commit added

#5 @iandstewart
12 years ago

  • Owner set to iandstewart
  • Resolution → fixed
  • Status new → closed

In 30099:

Twenty Fifteen: avoid errors by preventing Twenty Fifteen from being activated in old versions of WordPress

Props iamtakashi, fixes #30137.

This ticket was mentioned in ​Slack in #core-themes by morganestes. ​View the logs.


12 years ago

#7 @iandstewart
12 years ago

  • Resolution fixed
  • Status closed → reopened

This is breaking the customizer right now. I'll leave it in but comment it out in functions.php.

#8 @iandstewart
12 years ago

In 30103:

Twenty Fifteen: back compat checks in Twenty Fifteen are breaking the customizer, leaving them in for now, but commented out.

See #30137.

This ticket was mentioned in ​Slack in #core-themes by iandstewart. ​View the logs.


12 years ago

#10 @iandstewart
12 years ago

  • Keywords needs-refresh added; commit removed

#11 @SergeyBiryukov
12 years ago

Looking at [23825], we probably just need to change 4.1 to 4.1-alpha.

#12 @SergeyBiryukov
12 years ago

  • Resolution → fixed
  • Status reopened → closed

In 30116:

Twenty Fifteen: Change version compare string to '4.1-alpha' to avoid an error for alpha and beta testers during development.

fixes #30137.

Note: See TracTickets for help on using tickets.