WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#30137 closed defect (bug) (fixed)

Twenty Fifteen: Stop before 4.1 to activate the theme

Reported by: iamtakashi Owned by: iandstewart
Milestone: 4.1 Priority: normal
Severity: blocker Version: 4.1
Component: Bundled Theme Keywords: has-patch needs-refresh
Focuses: Cc:

Description

As a part of effort to make people update their install to the latest version, let's not allow before 4.1 to activate the theme.

Attachments (1)

30137.diff (3.3 KB) - added by iamtakashi 4 years ago.
Limit back compat to 4.1 and later versions.

Download all attachments as: .zip

Change History (13)

#1 @iandstewart
4 years ago

  • Milestone changed from Awaiting Review to 4.1
  • Severity changed from normal to blocker

#2 @iandstewart
4 years ago

  • Keywords needs-patch added

@iamtakashi
4 years ago

Limit back compat to 4.1 and later versions.

#3 @voldemortensen
4 years ago

  • Keywords has-patch added; needs-patch removed

#4 @iandstewart
4 years ago

  • Keywords commit added

#5 @iandstewart
4 years ago

  • Owner set to iandstewart
  • Resolution set to fixed
  • Status changed from new to closed

In 30099:

Twenty Fifteen: avoid errors by preventing Twenty Fifteen from being activated in old versions of WordPress

Props iamtakashi, fixes #30137.

This ticket was mentioned in Slack in #core-themes by morganestes. View the logs.


4 years ago

#7 @iandstewart
4 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

This is breaking the customizer right now. I'll leave it in but comment it out in functions.php.

#8 @iandstewart
4 years ago

In 30103:

Twenty Fifteen: back compat checks in Twenty Fifteen are breaking the customizer, leaving them in for now, but commented out.

See #30137.

This ticket was mentioned in Slack in #core-themes by iandstewart. View the logs.


4 years ago

#10 @iandstewart
4 years ago

  • Keywords needs-refresh added; commit removed

#11 @SergeyBiryukov
4 years ago

Looking at [23825], we probably just need to change 4.1 to 4.1-alpha.

#12 @SergeyBiryukov
4 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 30116:

Twenty Fifteen: Change version compare string to '4.1-alpha' to avoid an error for alpha and beta testers during development.

fixes #30137.

Note: See TracTickets for help on using tickets.