WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#30141 closed task (blessed) (fixed)

Update Grunt devDependencies in package.json

Reported by: jorbin Owned by: jorbin
Milestone: 4.1 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords:
Focuses: Cc:

Description

Many of our devDependencies are out of date. Let's update them to the latest version.

Attachments (1)

30141.diff (592 bytes) - added by jorbin 6 years ago.

Download all attachments as: .zip

Change History (15)

#1 @jorbin
6 years ago

In 30059:

Update grunt-contrib-imagemin to 0.9.1

Upstream changes https://github.com/gruntjs/grunt-contrib-imagemin/compare/v0.4.1...v0.9.1

see #30141

#4 @jorbin
6 years ago

In 30062:

Update grunt-contrib-clean to 0.6.0

Upstream changes https://github.com/gruntjs/grunt-contrib-clean/compare/v0.5.0...v0.6.0

see #30141

#5 @jorbin
6 years ago

In 30063:

Update grunt-contrib-copy to 0.7.0

Upstream changes https://github.com/gruntjs/grunt-contrib-copy/compare/v0.5.0...v0.7.0

see #30141

#6 @jorbin
6 years ago

In 30066:

Update grunt-contrib-uglify to 0.6.0

Upstream changes https://github.com/gruntjs/grunt-contrib-uglify/compare/v0.5.0...v0.6.0

see #30141

#7 @jorbin
6 years ago

In 30067:

Update grunt-autoprefixer to 1.0.1

Upstream changes https://github.com/nDmitry/grunt-autoprefixer/compare/v0.8.2...v1.0.1

see #30141

#8 @jorbin
6 years ago

In 30069:

Don't cascade autoprefixer output

Autoprefixer changed the default for cascade from false to true. Our css coding standards do not include the cascade for browser prefixes.
Introduced in r30067

see #30141

#9 @jorbin
6 years ago

In 30079:

Update images based on grunt imagemin

The new version of imagemin that was added in r30059 condenses some images more.

see #30141

#10 @jorbin
6 years ago

  • Owner set to jorbin
  • Status changed from new to assigned

Our devDependencies are now on the latest versions with the exception of grunt-cssjanus which still relies on the patched version added in r29505 and is still waiting merging upstream.

New output of npm outdated:

vagrant@vvv:/srv/www/wordpress-develop$ npm outdated --depth 0
Package         Current  Wanted  Latest  Location
grunt-cssjanus    0.2.2     git     git  grunt-cssjanus

#11 @jorbin
6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

#12 @netweb
6 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Rerunning grunt imagemin results in images still being minified:

Per @Ocean90 https://wordpress.slack.com/archives/core/p1414623992002617

jorbin: Running grunt imagemin still results in Minified 142 images (saved 381 B).

Running grunt imagemin --debug --verbose on my local machine results in the following three files:

 src/wp-admin/images/icons32-vs-2x.png (saved 49 B - 0%)
 src/wp-includes/images/wpicons.png (saved 97 B - 1%)
 src/wp-includes/images/wpicons-2x.png (saved 145 B - 1%)

Minified 142 images (saved 292 B)

My results do not match up with Ocean90's (saved 381 B)

FYI: I'm using Windows x64 with "all the things" (NodeJS, NPM, Grunt-CLI etc) updated and current as far as I can tell.

#13 @ocean90
6 years ago

These are my results on OS X 10.10:

✔ src/wp-includes/images/blank.gif (already optimized)
✔ src/wp-includes/js/tinymce/skins/wordpress/images/embedded.png (saved 147 B - 2%)
✔ src/wp-includes/images/wpicons.png (saved 92 B - 1%)
✔ src/wp-includes/images/wpicons-2x.png (saved 142 B - 1%)
Minified 142 images (saved 381 B)

$ svn st
M       src/wp-includes/images/blank.gif
M       src/wp-includes/images/wpicons-2x.png
M       src/wp-includes/images/wpicons.png
M       src/wp-includes/js/tinymce/skins/wordpress/images/embedded.png

@jorbin
6 years ago

#14 @ocean90
6 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 30563:

Update embedded.png after running grunt imagemin.

After [30059] and [30079] we still had four images which could be minified. Three of them are handled by [30562], the last one by this.

fixes #30141.

Note: See TracTickets for help on using tickets.